[PATCH] D139028: [RFC][clang] Add attribute-like keywords

rsandifo-arm abandoned this revision. rsandifo-arm added a comment. Superceded by D148700 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139028/new/ https://reviews.llvm.org/D139028

[PATCH] D139028: [RFC][clang] Add attribute-like keywords

rsandifo-arm added a comment. Thanks @aaron.ballman and @erichkeane for the comments. I'll split it into stages and use tablegen more, like you say. In D139028#4150761 , @aaron.ballman wrote: > One thing that might also help is to split this into a

[PATCH] D139028: [RFC][clang] Add attribute-like keywords

erichkeane added a comment. In D139028#4150761 , @aaron.ballman wrote: > One thing that might also help is to split this into a few stages. 1) Add the > new general functionality, 2) Replacing the existing implementation of > keyword attributes with

[PATCH] D139028: [RFC][clang] Add attribute-like keywords

aaron.ballman added a comment. One thing that might also help is to split this into a few stages. 1) Add the new general functionality, 2) Replacing the existing implementation of keyword attributes with the new functionality where possible, 3) Add new attributes using the new functionality.

[PATCH] D139028: [RFC][clang] Add attribute-like keywords

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. Roping in Erich as the attributes code owner. In general, I think this is going in roughly the right direction. One concern I have is that the distinction between a keyword spelling for an attribute is now a bit harder.

[PATCH] D139028: [RFC][clang] Add attribute-like keywords

rsandifo-arm added a comment. Ping. If this approach is acceptable, I think we could use it for future ACLE features too (rather than the GNU attributes that we've used previously). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139028/new/