[PATCH] D139429: [clang] Add test for CWG418

This revision was automatically updated to reflect the committed changes. Closed by commit rG90d4cbb87ce2: [clang] Add test for CWG418 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139429/new/ https://reviews.llvm.org/D139429

[PATCH] D139429: [clang] Add test for CWG418

Endill added a comment. Thanks to all of you for your time to review this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139429/new/ https://reviews.llvm.org/D139429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D139429: [clang] Add test for CWG418

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM, thank you for all your efforts. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139429/new/ https://reviews.llvm.org/D139429 ___

[PATCH] D139429: [clang] Add test for CWG418

Endill updated this revision to Diff 480848. Endill edited the summary of this revision. Endill added a comment. Add example from [over.match.best]/4, and mark CWG418 as not available CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139429/new/ https://reviews.llvm.org/D139429 Files:

[PATCH] D139429: [clang] Add test for CWG418

shafik added a comment. In D139429#3975223 , @Endill wrote: > @shafik does this imply that example from [over.match.best]/4 should be > included in this patch? Yes, I believe we should. We are only conforming if we get all of the cases correct.

[PATCH] D139429: [clang] Add test for CWG418

Endill added a comment. @shafik does this imply that example from [over.match.best]/4 should be included in this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139429/new/ https://reviews.llvm.org/D139429

[PATCH] D139429: [clang] Add test for CWG418

shafik added a subscriber: aaron.ballman. shafik added a comment. In D139429#3975028 , @Endill wrote: > I opened #59363 on bug > tracker. > What should I do about this patch then? I believe

[PATCH] D139429: [clang] Add test for CWG418

Endill added a comment. I opened #59363 on bug tracker. What should I do about this patch then? I believe availability `no` should come with a failing test. Should I include example from [over.match.best]/4 as another example in the test?

[PATCH] D139429: [clang] Add test for CWG418

shafik added a comment. In D139429#3974745 , @Endill wrote: >> I think the relevant change from p1787 is to dcl.fct.default p4, >> specifically: >> >>> ... Declarations that inhabit different scopes have completely distinct >>> sets of default

[PATCH] D139429: [clang] Add test for CWG418

Endill added a comment. > I think the relevant change from p1787 is to dcl.fct.default p4, specifically: > >> ... Declarations that inhabit different scopes have completely distinct sets >> of default arguments ... It previously said "Declarations __in__ different scopes". To me it's no more

[PATCH] D139429: [clang] Add test for CWG418

shafik added a comment. In D139429#3974491 , @cor3ntin wrote: > I'm not sure how I feel about this. > Clang does not, implement correctly that paragraph at all, so I think the > best course here is to create an issue on the llvm github and mark the dr

[PATCH] D139429: [clang] Add test for CWG418

shafik added a comment. I think the relevant change from p1787 is to dcl.fct.default p4 , specifically: > ... Declarations that inhabit different scopes have completely distinct

[PATCH] D139429: [clang] Add test for CWG418

cor3ntin added a comment. I'm not sure how I feel about this. Clang does not, implement correctly that paragraph at all, so I think the best course here is to create an issue on the llvm github and mark the dr resolved as part of fixing the bug in clang. The fact the previous wording was

[PATCH] D139429: [clang] Add test for CWG418

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : //CWG418