[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

2022-12-12 Thread Paul Robinson via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7793e676514b: [ZOS] Convert tests to check target={{.*}}-zos{{.*}} (authored by probinson). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

2022-12-12 Thread Ulrich Weigand via Phabricator via cfe-commits
uweigand accepted this revision. uweigand added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139444/new/ https://reviews.llvm.org/D139444 ___ cfe-commits mailing list

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

2022-12-12 Thread Paul Robinson via Phabricator via cfe-commits
probinson added a comment. Thanks @Kai and @uweigand, good to know a z/OS bot is in the works. Hope this patch now meets your needs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139444/new/ https://reviews.llvm.org/D139444 ___ cfe-commits

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

2022-12-12 Thread Paul Robinson via Phabricator via cfe-commits
probinson updated this revision to Diff 482180. probinson added a comment. Herald added a subscriber: delcypher. Define 'system-zos' and use it in the one test that needs it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139444/new/ https://reviews.llvm.org/D139444 Files:

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

2022-12-12 Thread Kai Nacke via Phabricator via cfe-commits
Kai added a comment. In D139444#3988544 , @probinson wrote: > Searching the buildbot console page for 'zos' turns up nothing; 's390' turns > up clang-s390x-linux, clang-s390x-linux-lnt, mlir-s390x-linux. Are there any > zos hosted bots? I.e., is this

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

2022-12-12 Thread Kai Nacke via Phabricator via cfe-commits
Kai added a comment. In D139444#3978189 , @uweigand wrote: > In D139444#3975182 , @probinson > wrote: > >> The changes in this patch assume that there aren't any possible suffixes >> after the `-zos` part of

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

2022-12-12 Thread Kai Nacke via Phabricator via cfe-commits
Kai added a comment. In D139444#3982205 , @probinson wrote: > If you can tell me the `platform.system()` value to look for to detect z/OS, > I can do that. Probably as a separate patch, as it would be going beyond the > mechanical replacement that I'm

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

2022-12-12 Thread Paul Robinson via Phabricator via cfe-commits
probinson added a comment. I suppose we could temporarily add a test that does ; REQUIRES: target={{.*}}-zos ; RUN: %python -c 'import platform; print(platform.system())' && false and see what gets printed. Searching the buildbot console page for 'zos' turns up nothing; 's390' turns up

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

2022-12-09 Thread Ulrich Weigand via Phabricator via cfe-commits
uweigand added a comment. In D139444#3983679 , @uweigand wrote: > In D139444#3982205 , @probinson > wrote: > >> If you can tell me the `platform.system()` value to look for to detect z/OS, >> I can do that. > >

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

2022-12-09 Thread Ulrich Weigand via Phabricator via cfe-commits
uweigand added a comment. In D139444#3982205 , @probinson wrote: > If you can tell me the `platform.system()` value to look for to detect z/OS, > I can do that. I don't know - this value is defined by the Python implementation on z/OS. On most

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

2022-12-08 Thread Paul Robinson via Phabricator via cfe-commits
probinson updated this revision to Diff 481421. probinson added a comment. Add trailing '{{.*}}' as requested. Have not changed the encoding.ll test, waiting on @uweigand about correct value to test in Python. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139444/new/

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

2022-12-08 Thread Paul Robinson via Phabricator via cfe-commits
probinson added a comment. In D139444#3978189 , @uweigand wrote: > In D139444#3975182 , @probinson > wrote: > >> The changes in this patch assume that there aren't any possible suffixes >> after the `-zos` part

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

2022-12-07 Thread Ulrich Weigand via Phabricator via cfe-commits
uweigand added a comment. In D139444#3975182 , @probinson wrote: > The changes in this patch assume that there aren't any possible suffixes > after the `-zos` part of the triple (no version numbers, like you might find > with darwin or macos, and

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

2022-12-06 Thread Paul Robinson via Phabricator via cfe-commits
probinson added a comment. The changes in this patch assume that there aren't any possible suffixes after the `-zos` part of the triple (no version numbers, like you might find with darwin or macos, and nothing like `-elf` or `-eabi` like some targets have). If there are suffixes, I'll

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

2022-12-06 Thread Paul Robinson via Phabricator via cfe-commits
probinson created this revision. probinson added reviewers: uweigand, Kai. Herald added a project: All. probinson requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Part of the project to eliminate special handling for