[PATCH] D139450: Warn about unsupported ibmlongdouble

qiucf added a comment. Committed as https://github.com/llvm/llvm-project/commit/5f68c4111ab9c79b902723df3986dd1033813c01 `ppc-float-abi-warning.cpp` would fail when testing on machine with glibc older than 2.32 but `PPC_LINUX_DEFAULT_IEEELONGDOUBLE` enabled, which is known failure even before

[PATCH] D139450: Warn about unsupported ibmlongdouble

This revision was automatically updated to reflect the committed changes. Closed by commit rG5f68c4111ab9: Warn about unsupported ibmlongdouble (authored by tuliom, committed by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139450/new/

[PATCH] D139450: Warn about unsupported ibmlongdouble

tuliom marked an inline comment as done. tuliom added a comment. Thanks @qiucf ! I don't have commit access yet. Could you land this patch for me, please? Please use “Tulio Magno Quites Machado Filho tul...@redhat.com” to commit the change. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D139450: Warn about unsupported ibmlongdouble

tuliom marked 2 inline comments as done. tuliom added inline comments. Comment at: clang/test/Driver/lit.local.cfg:26 +if config.ppc_linux_default_ieeelongdouble == "ON": + config.available_features.add('ppc_linux_default_ieeelongdouble') qiucf wrote: > tuliom

[PATCH] D139450: Warn about unsupported ibmlongdouble

qiucf added inline comments. Comment at: clang/test/Driver/lit.local.cfg:26 +if config.ppc_linux_default_ieeelongdouble == "ON": + config.available_features.add('ppc_linux_default_ieeelongdouble') tuliom wrote: > qiucf wrote: > > Can we assume if we are

[PATCH] D139450: Warn about unsupported ibmlongdouble

tuliom marked 3 inline comments as done. tuliom added inline comments. Comment at: clang/lib/Driver/ToolChains/PPCLinux.cpp:74 +const Driver , +const llvm::opt::ArgList ) const { + if (Args.hasArg(options::OPT_nostdlib, options::OPT_nostdlibxx)) nikic

[PATCH] D139450: Warn about unsupported ibmlongdouble

tuliom updated this revision to Diff 481730. tuliom added a comment. Fix the issues pointed by @nikic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139450/new/ https://reviews.llvm.org/D139450 Files: clang/lib/Driver/ToolChains/PPCLinux.cpp

[PATCH] D139450: Warn about unsupported ibmlongdouble

tuliom added a comment. In D139450#3981486 , @qiucf wrote: > Thanks for the patch! But does libc++ support to be built with > `-mabi=ieeelongdouble` now? @qiucf libc++ can be built with `-mabi=ieeelongdouble`, but it supports only a single long double

[PATCH] D139450: Warn about unsupported ibmlongdouble

qiucf added a comment. Thanks for the patch! But does libc++ support to be built with `-mabi=ieeelongdouble` now? (like libstdc++, if it works correctly, it should co-exist and be linked with different long double ABIs) Comment at: clang/lib/Driver/ToolChains/PPCLinux.cpp:96

[PATCH] D139450: Warn about unsupported ibmlongdouble

nikic added inline comments. Comment at: clang/lib/Driver/ToolChains/PPCLinux.cpp:74 +const Driver , +const llvm::opt::ArgList ) const { + if (Args.hasArg(options::OPT_nostdlib, options::OPT_nostdlibxx)) I don't think this formatting is right. You may

[PATCH] D139450: Warn about unsupported ibmlongdouble

tuliom updated this revision to Diff 480858. tuliom added a comment. I'm attaching a new version of the patch. > Can you please upload the patch with full context (-U9)? @nikic Done! > The assumption here is that libc++ is being compiled with a compiler that has > the same ieeelongdouble

[PATCH] D139450: Warn about unsupported ibmlongdouble

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/PPCLinux.h:30 const llvm::opt::ArgList ) const; + bool SupportIBMLongDouble(const Driver , +const llvm::opt::ArgList ) const; New

[PATCH] D139450: Warn about unsupported ibmlongdouble

nikic added a reviewer: PowerPC. nikic added a comment. Can you please upload the patch with full context (`-U9`)? The assumption here is that `libc++` is being compiled with a compiler that has the same ieeelongdouble default as the clang that is being built, right? I guess that's the

[PATCH] D139450: Warn about unsupported ibmlongdouble

tuliom created this revision. tuliom added projects: clang, PowerPC. Herald added a subscriber: kbarton. Herald added a project: All. tuliom requested review of this revision. Herald added a subscriber: MaskRay. When -mabi=ieeelongdouble is enabled by default, libc++ does not support