This revision was automatically updated to reflect the committed changes.
Closed by commit rGe67f849001bb: [CMake] Replace clang binary if using
clang-bolt target (authored by Amir).
Changed prior to commit:
https://reviews.llvm.org/D139454?vs=492638=493025#toc
Repository:
rG LLVM Github
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139454/new/
https://reviews.llvm.org/D139454
Amir updated this revision to Diff 492638.
Amir added a comment.
Use generator expression, put clang-bolt temp binary to CMAKE_CURRENT_BINARY_DIR
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139454/new/
https://reviews.llvm.org/D139454
Files:
phosek added inline comments.
Comment at: clang/CMakeLists.txt:959
)
add_custom_command(OUTPUT ${CLANG_OPTIMIZED}
DEPENDS clang-bolt-profile
We should consider placing this and all other intermediate outputs in
`${CMAKE_CURRENT_BINARY_DIR}`.
Amir added a comment.
Ping @phosek @MaskRay
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139454/new/
https://reviews.llvm.org/D139454
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Amir created this revision.
Amir added reviewers: bolt, phosek, MaskRay.
Herald added subscribers: StephenFan, wenlei.
Herald added a project: All.
Amir requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
Instead of creating
