[PATCH] D139608: [Clang][NFC] Add default `getBFloat16Mangling` impl

Pierre-vh abandoned this revision. Pierre-vh added a comment. Makes sense to abandon this given that D136919 exists Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139608/new/ https://reviews.llvm.org/D139608

[PATCH] D139608: [Clang][NFC] Add default `getBFloat16Mangling` impl

stuij added a comment. I went back and forth on this for a bit. There's a review outstanding to change the mangling name for X86: https://reviews.llvm.org/D136919 to align with the C++23 std::bfloat16_t issue from above. I settled on preferring to be conservative, and not risk at some point

[PATCH] D139608: [Clang][NFC] Add default `getBFloat16Mangling` impl

Pierre-vh added a comment. Ping? it's a small NFC and if it's not desired I don't mind abandoning it; I'd just like to remove this diff from the queue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139608/new/ https://reviews.llvm.org/D139608

[PATCH] D139608: [Clang][NFC] Add default `getBFloat16Mangling` impl

Pierre-vh added a comment. In D139608#3982494 , @jcranmer-intel wrote: > I don't normally handle name mangling, so I can't comment too much here, but > I will note that Itanium ABI is planning on using DF16b for > `std::bfloat16_t`:

[PATCH] D139608: [Clang][NFC] Add default `getBFloat16Mangling` impl

jcranmer-intel added a comment. I don't normally handle name mangling, so I can't comment too much here, but I will note that Itanium ABI is planning on using DF16b for `std::bfloat16_t`: https://github.com/itanium-cxx-abi/cxx-abi/pull/147 Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D139608: [Clang][NFC] Add default `getBFloat16Mangling` impl

Pierre-vh created this revision. Pierre-vh added reviewers: MaskRay, stuij. Herald added subscribers: kosarev, mattd, gchakrabarti, asavonic, StephenFan, kerbowa, jvesely. Herald added a project: All. Pierre-vh requested review of this revision. Herald added subscribers: cfe-commits, jholewinski.