[PATCH] D139632: [clang-cl] Ignore #pragma managed / #pragma unmanaged

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG822c274477ea: [clang-cl] Ignore #pragma managed/unmanaged (authored by saudi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D139632: [clang-cl] Ignore #pragma managed / #pragma unmanaged

thieta added a comment. It still looks odd to me, but since the rest of the file has comments like that I am fine with it. But I think we should figure out if they are like that because some tool is parsing them or if it's just legacy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D139632: [clang-cl] Ignore #pragma managed / #pragma unmanaged

saudi added a comment. In D139632#3985341 , @thakis wrote: > LG (except for thieta's nit.) > > Do you have commit permissions, or do you need someone to land this for you? > If the latter, which name and email should we use for landing it? I have

[PATCH] D139632: [clang-cl] Ignore #pragma managed / #pragma unmanaged

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. LG (except for thieta's nit.) Do you have commit permissions, or do you need someone to land this for you? If the latter, which name and email should we use for landing it? Repository: rG

[PATCH] D139632: [clang-cl] Ignore #pragma managed / #pragma unmanaged

thieta added inline comments. Comment at: clang/lib/Lex/Pragma.cpp:1960 +/// "\#pragma managed" +/// "\#pragma managed(...)" I don't see the other comments in this file having `"\#` I think you can drop that. Also two `/` for the comments, not three.

[PATCH] D139632: [clang-cl] Ignore #pragma managed / #pragma unmanaged

saudi created this revision. saudi added reviewers: thakis, rnk, thieta. saudi added a project: clang. Herald added a project: All. saudi requested review of this revision. Herald added a subscriber: cfe-commits. Those 2 pragmas are ignored by MSVC when not compiling with `/CLR`, which clang