[PATCH] D139652: Add the thread sanitizer support for X86_64 WatchOS simulators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0073fd8d0dda: Add the thread sanitizer support for X86_64 WatchOS simulators (authored by yfyang, committed by oontvoo). Repository: rG LLVM

[PATCH] D139652: Add the thread sanitizer support for X86_64 WatchOS simulators

yfyang updated this revision to Diff 481684. yfyang added a comment. - Add TSAN support for Apple arm64 simulators - Formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139652/new/ https://reviews.llvm.org/D139652 Files:

[PATCH] D139652: Add the thread sanitizer support for X86_64 WatchOS simulators

yfyang updated this revision to Diff 481682. yfyang added a comment. Formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139652/new/ https://reviews.llvm.org/D139652 Files: clang/lib/Driver/ToolChains/Darwin.cpp Index:

[PATCH] D139652: Add the thread sanitizer support for X86_64 WatchOS simulators

yfyang updated this revision to Diff 481679. yfyang added a comment. Addressing comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139652/new/ https://reviews.llvm.org/D139652 Files: clang/lib/Driver/ToolChains/Darwin.cpp

[PATCH] D139652: Add the thread sanitizer support for X86_64 WatchOS simulators

rsundahl added a comment. In D139652#3983079 , @yln wrote: > @rsundahl: can you keep an eye on this and resolve any potential > Apple-internal conflicts? Thanks! Will do @yln. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D139652: Add the thread sanitizer support for X86_64 WatchOS simulators

yln accepted this revision. yln added a subscriber: rsundahl. yln added a comment. Thank you! LGTM, with one nit. @rsundahl: can you keep an eye on this and resolve potential conflicts? Thanks! Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:3280-3286 if ((IsX86_64 ||

[PATCH] D139652: Add the thread sanitizer support for X86_64 WatchOS simulators

jyknight accepted this revision. jyknight added a comment. This revision is now accepted and ready to land. Thanks for the change. The description is a bit misleading, this would be better: Allow TSan in clang driver for X86_64 WatchOS simulator. It was already functional, and Apple's

[PATCH] D139652: Add the thread sanitizer support for X86_64 WatchOS simulators

yfyang created this revision. yfyang added a reviewer: jyknight. Herald added a subscriber: pengfei. Herald added a project: All. yfyang requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Thread sanitizer for x86_64 architecutre is