Re: [PATCH] D13969: Tweak how -Wunused-value interacts with macros

2015-10-27 Thread Nico Weber via cfe-commits
thakis closed this revision. thakis marked an inline comment as done. thakis added a comment. Done and landed in r251441, thanks! http://reviews.llvm.org/D13969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

Re: [PATCH] D13969: Tweak how -Wunused-value interacts with macros

2015-10-27 Thread Reid Kleckner via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, I don't feel strongly about whether -fms-compatibility matters, but I'd prefer that it didn't. Comment at: lib/Sema/SemaStmt.cpp:224 @@ +223,3 @@ + // but its implementation

Re: [PATCH] D13969: Tweak how -Wunused-value interacts with macros

2015-10-26 Thread Nico Weber via cfe-commits
thakis added a reviewer: rnk. thakis added a comment. rnk: Can you look at this if Richard is still away doing committee thing? http://reviews.llvm.org/D13969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

Re: [PATCH] D13969: Tweak how -Wunused-value interacts with macros

2015-10-21 Thread Nico Weber via cfe-commits
thakis added a comment. Sorry about all the emails, I didn't realize that editing the description would send an update every time. Looks like phab's markup language doesn't support code blocks in lists (https://secure.phabricator.com/T4939). The description looks ok in email but broken on phab.

[PATCH] D13969: Tweak how -Wunused-value interacts with macros

2015-10-21 Thread Nico Weber via cfe-commits
thakis created this revision. thakis added a reviewer: rsmith. thakis added a subscriber: cfe-commits. 1. Make the warning more strict in C mode. r172696 added code to suppress warnings from macro expansions in system headers, which checks `SourceMgr.isMacroBodyExpansion(E->IgnoreParens()->getEx