[PATCH] D139704: [clang][RISCV] Added target attributes to runtime functions

eklepilkina added a comment. Gently ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139704/new/ https://reviews.llvm.org/D139704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D139704: [clang][RISCV] Added target attributes to runtime functions

eklepilkina added a comment. Gently ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139704/new/ https://reviews.llvm.org/D139704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D139704: [clang][RISCV] Added target attributes to runtime functions

eklepilkina added a comment. I've created one more patch connected with lto https://reviews.llvm.org/D142191 and it also uses attributes of functions as the way to get right TargetMachine in linker. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D139704: [clang][RISCV] Added target attributes to runtime functions

eklepilkina added a comment. > How does this affect LTO? More detailed answer. We work with bitcode files only when use `lto`. If we don't use `lto` clang produces `.o` file that are already contains target information. We don't work with function attributes to get subtarget without lto.

[PATCH] D139704: [clang][RISCV] Added target attributes to runtime functions

eklepilkina added a comment. > How does this affect LTO? This problem appeared only under lto as far as it's processed as one module. > Is this not just one of many symptoms of RISC-V not having the right > module-level subtarget under LTO, which is a real problem that needs fixing? Not

[PATCH] D139704: [clang][RISCV] Added target attributes to runtime functions

erichkeane added a subscriber: eli.friedman. erichkeane added a comment. The code changes/test changes seem innocuous enough, so from an 'attribute code owner perspective' I think this is alright. I think @rjmccall or @eli.friedman need to take a peak from CodeGen owner's perspective, and it

[PATCH] D139704: [clang][RISCV] Added target attributes to runtime functions

jrtc27 added a comment. How does this affect LTO? LTO for RISC-V is broken for various reasons, but LTO isn't Clang's responsibility beyond passing on driver arguments. Is this not just one of many symptoms of RISC-V not having the right module-level subtarget under LTO, which is a real

[PATCH] D139704: [clang][RISCV] Added target attributes to runtime functions

eklepilkina added a comment. Herald added a subscriber: luke. Gently ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139704/new/ https://reviews.llvm.org/D139704 ___ cfe-commits mailing list

[PATCH] D139704: [clang][RISCV] Added target attributes to runtime functions

eklepilkina added a comment. Gently ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139704/new/ https://reviews.llvm.org/D139704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D139704: [clang][RISCV] Added target attributes to runtime functions

eklepilkina created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng,