[PATCH] D139928: [clang][DebugInfo] Backport emitting DW_AT_default_value for default template arguments

2022-12-13 Thread Michael Buch via Phabricator via cfe-commits
Michael137 added a comment. In D139928#3992233 , @dblaikie wrote: > (This should be committed in two parts - the LLVM part first, then the Clang > part - since they can be separated, they should be - but happy to review it > altogether) Split the

[PATCH] D139928: [clang][DebugInfo] Backport emitting DW_AT_default_value for default template arguments

2022-12-13 Thread Michael Buch via Phabricator via cfe-commits
Michael137 updated this revision to Diff 482533. Michael137 added a comment. - Split clang and llvm changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139928/new/ https://reviews.llvm.org/D139928 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D139928: [clang][DebugInfo] Backport emitting DW_AT_default_value for default template arguments

2022-12-13 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. (This should be committed in two parts - the LLVM part first, then the Clang part - since they can be separated, they should be - but happy to review it altogether) Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp:1856 + +bool

[PATCH] D139928: [clang][DebugInfo] Backport emitting DW_AT_default_value for default template arguments

2022-12-13 Thread Michael Buch via Phabricator via cfe-commits
Michael137 updated this revision to Diff 482419. Michael137 added a comment. - Fix test formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139928/new/ https://reviews.llvm.org/D139928 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D139928: [clang][DebugInfo] Backport emitting DW_AT_default_value for default template arguments

2022-12-13 Thread Michael Buch via Phabricator via cfe-commits
Michael137 created this revision. Michael137 added reviewers: aprantl, dblaikie. Herald added a subscriber: hiraditya. Herald added a project: All. Michael137 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. With this