Michael137 added a comment.
committed in `98afcbab66505661045dccb85ee9acdbf9410047`
Missed phab link in commit message
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139985/new/
https://reviews.llvm.org/D139985
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Looks good, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139985/new/
https://reviews.llvm.org/D139985
Michael137 updated this revision to Diff 483342.
Michael137 added a comment.
- Don't create separate component. Instead move API into Type.h
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139985/new/
https://reviews.llvm.org/D139985
Files:
dblaikie added inline comments.
Comment at: clang/include/clang/AST/TemplateUtils.h:19
+namespace clang {
+namespace TemplateUtils {
+/// Make a best-effort determination of whether the type T can be produced by
aprantl wrote:
> Michael137 wrote:
> > dblaikie
aprantl added inline comments.
Comment at: clang/include/clang/AST/TemplateUtils.h:19
+namespace clang {
+namespace TemplateUtils {
+/// Make a best-effort determination of whether the type T can be produced by
Michael137 wrote:
> dblaikie wrote:
> > aprantl
Michael137 added inline comments.
Comment at: clang/include/clang/AST/TemplateUtils.h:19
+namespace clang {
+namespace TemplateUtils {
+/// Make a best-effort determination of whether the type T can be produced by
dblaikie wrote:
> aprantl wrote:
> > It looks
dblaikie added inline comments.
Comment at: clang/include/clang/AST/TemplateUtils.h:19
+namespace clang {
+namespace TemplateUtils {
+/// Make a best-effort determination of whether the type T can be produced by
aprantl wrote:
> It looks like all the other
aprantl added a comment.
Seems fine to me, I just have one inline comment about the name of the
namespace.
Comment at: clang/include/clang/AST/TemplateUtils.h:19
+namespace clang {
+namespace TemplateUtils {
+/// Make a best-effort determination of whether the type T can be
Michael137 created this revision.
Michael137 added a reviewer: aprantl.
Herald added a project: All.
Michael137 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
A use-case has come up in DWARF CodeGen where we want to determine
whether a
