[PATCH] D140270: MIPS: fix build from IR files, nan2008 and FpAbi

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4b95dee3140: MIPS: fix build from IR files, nan2008 and FpAbi (authored by wzssyqa, committed by MaskRay). Repository: rG LLVM Github Monorepo

[PATCH] D140270: MIPS: fix build from IR files, nan2008 and FpAbi

wzssyqa added a comment. @MaskRay can you help to submit this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140270/new/ https://reviews.llvm.org/D140270 ___ cfe-commits mailing list

[PATCH] D140270: MIPS: fix build from IR files, nan2008 and FpAbi

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140270/new/ https://reviews.llvm.org/D140270

[PATCH] D140270: MIPS: fix build from IR files, nan2008 and FpAbi

nathanchance added a comment. I tested this against the kernel and left my feedback above (no issues) so this can be merged. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140270/new/ https://reviews.llvm.org/D140270

[PATCH] D140270: MIPS: fix build from IR files, nan2008 and FpAbi

MaskRay added a comment. In D140270#4089857 , @wzssyqa wrote: > ping I don't know how to test this, so this will be up to @nathanchance ... (Thanks for improving the mips port, though) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140270: MIPS: fix build from IR files, nan2008 and FpAbi

wzssyqa added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140270/new/ https://reviews.llvm.org/D140270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D140270: MIPS: fix build from IR files, nan2008 and FpAbi

wzssyqa updated this revision to Diff 485898. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140270/new/ https://reviews.llvm.org/D140270 Files: clang/lib/Driver/ToolChains/Arch/Mips.cpp clang/test/Driver/mips-as.c

[PATCH] D140270: MIPS: fix build from IR files, nan2008 and FpAbi

wzssyqa updated this revision to Diff 485897. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140270/new/ https://reviews.llvm.org/D140270 Files: clang/lib/Driver/ToolChains/Arch/Mips.cpp clang/test/Driver/mips-as.c

[PATCH] D140270: MIPS: fix build from IR files, nan2008 and FpAbi

nathanchance added a comment. This does not show any issues with any of the MIPS configurations that I build in the Linux kernel, thanks for fixing the problems I reported! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140270/new/

[PATCH] D140270: MIPS: fix build from IR files, nan2008 and FpAbi

MaskRay added inline comments. Comment at: llvm/test/CodeGen/Mips/abiflags-2008-fp64.ll:1 +; RUN: llc %s -o - | FileCheck %s + Add `;; ` file-level comment what this test does. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140270: MIPS: fix build from IR files, nan2008 and FpAbi

wzssyqa added a comment. @nathanchance can you have a try this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140270/new/ https://reviews.llvm.org/D140270 ___ cfe-commits mailing list

[PATCH] D140270: MIPS: fix build from IR files, nan2008 and FpAbi

wzssyqa updated this revision to Diff 485793. wzssyqa retitled this revision from "MIPS: emit .module and .nan directives only for first function" to "MIPS: fix build from IR files, nan2008 and FpAbi". wzssyqa edited the summary of this revision. Herald added a project: clang. Herald added a