This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG310eea1c78e3: [OpenMP] Migrate OpenMPOffloadMappingFlags
from Clang CodeGen to OMPConstants (authored by TIFitis).
Repository:
rG LLVM Github
TIFitis updated this revision to Diff 487179.
TIFitis added a comment.
Missed the other llvm::find_if in previous revision. This should fix Windows
build issues.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140292/new/
TIFitis updated this revision to Diff 487171.
TIFitis added a comment.
Second attempt at fixing windows build issue.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140292/new/
https://reviews.llvm.org/D140292
Files:
TIFitis updated this revision to Diff 486787.
TIFitis added a comment.
Fixed Windows build issues,
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140292/new/
https://reviews.llvm.org/D140292
Files:
clang/lib/CodeGen/CGOpenMPRuntime.cpp
jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
LG, thx
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140292/new/
https://reviews.llvm.org/D140292
TIFitis updated this revision to Diff 486360.
TIFitis added a comment.
Fixed clang-format issues.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140292/new/
https://reviews.llvm.org/D140292
Files:
clang/lib/CodeGen/CGOpenMPRuntime.cpp
jdoerfert added a comment.
Can you please check why there are so many reformatted lines are part of this
patch? Is the clang-format version up to date? Maybe it changed but we should
only format the parts touched by the patch, hence `git-clang-format HEAD~`
rather than format everything.
TIFitis updated this revision to Diff 486224.
TIFitis marked an inline comment as done.
TIFitis added a comment.
Changed OpenMPOffloadMappingFlags from enum to enum class. This resolves the
conflict with LLVM_MARK_AS_BITMASK_ENUM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
TIFitis marked 2 inline comments as done.
TIFitis added inline comments.
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:193
- OMP_TGT_EXEC_MODE_GENERIC | OMP_TGT_EXEC_MODE_SPMD,
- LLVM_MARK_AS_BITMASK_ENUM(/* LargestValue */ OMP_TGT_EXEC_MODE_GENERIC_SPMD)
jdoerfert added inline comments.
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:193
- OMP_TGT_EXEC_MODE_GENERIC | OMP_TGT_EXEC_MODE_SPMD,
- LLVM_MARK_AS_BITMASK_ENUM(/* LargestValue */ OMP_TGT_EXEC_MODE_GENERIC_SPMD)
};
TIFitis wrote:
>
TIFitis marked an inline comment as done.
TIFitis added inline comments.
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:193
- OMP_TGT_EXEC_MODE_GENERIC | OMP_TGT_EXEC_MODE_SPMD,
- LLVM_MARK_AS_BITMASK_ENUM(/* LargestValue */ OMP_TGT_EXEC_MODE_GENERIC_SPMD)
jdoerfert added inline comments.
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:193
- OMP_TGT_EXEC_MODE_GENERIC | OMP_TGT_EXEC_MODE_SPMD,
- LLVM_MARK_AS_BITMASK_ENUM(/* LargestValue */ OMP_TGT_EXEC_MODE_GENERIC_SPMD)
};
TIFitis wrote:
> I am
TIFitis added inline comments.
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:193
- OMP_TGT_EXEC_MODE_GENERIC | OMP_TGT_EXEC_MODE_SPMD,
- LLVM_MARK_AS_BITMASK_ENUM(/* LargestValue */ OMP_TGT_EXEC_MODE_GENERIC_SPMD)
};
I am not sure if this
TIFitis created this revision.
TIFitis added reviewers: kiranchandramohan, clementval, jdoerfert, jsjodin.
Herald added subscribers: guansong, yaxunl.
Herald added a project: All.
TIFitis requested review of this revision.
Herald added subscribers: llvm-commits, cfe-commits, sstefan1.
Herald added
14 matches
Mail list logo
