[PATCH] D140332: [ADT] Alias llvm::Optional to std::optional

kazu added a comment. Thank you for this patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140332/new/ https://reviews.llvm.org/D140332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D140332: [ADT] Alias llvm::Optional to std::optional

barannikov88 accepted this revision. barannikov88 added inline comments. Comment at: llvm/lib/CodeGen/RegAllocGreedy.h:83 public: -ExtraRegInfo() = default; +ExtraRegInfo() {} ExtraRegInfo(const ExtraRegInfo &) = delete; bkramer wrote: >

[PATCH] D140332: [ADT] Alias llvm::Optional to std::optional

bkramer marked an inline comment as done. bkramer added a comment. In D140332#4005988 , @MaskRay wrote: > Can you push `using OptionalFileEntryRef = > CustomizableOptional;` and the renaming as a separate commit to > make this patch smaller? > There is

[PATCH] D140332: [ADT] Alias llvm::Optional to std::optional

bkramer marked an inline comment as done. bkramer added inline comments. Comment at: clang/lib/Basic/TargetInfo.cpp:513 if (Opts.MaxBitIntWidth) -MaxBitIntWidth = Opts.MaxBitIntWidth; +MaxBitIntWidth = (unsigned)Opts.MaxBitIntWidth; barannikov88

[PATCH] D140332: [ADT] Alias llvm::Optional to std::optional

MaskRay added a comment. Can you push `using OptionalFileEntryRef = CustomizableOptional;` and the renaming as a separate commit to make this patch smaller? There is a smaller that this rename may be reverted. 205c0589f918f95d2f2c586a01bea2716d73d603

[PATCH] D140332: [ADT] Alias llvm::Optional to std::optional

barannikov88 added inline comments. Comment at: clang/lib/Basic/TargetInfo.cpp:513 if (Opts.MaxBitIntWidth) -MaxBitIntWidth = Opts.MaxBitIntWidth; +MaxBitIntWidth = (unsigned)Opts.MaxBitIntWidth; Nit: C-style casts are generally discouraged (there

[PATCH] D140332: [ADT] Alias llvm::Optional to std::optional

probinson added a comment. Herald added subscribers: jsetoain, JDevlieghere, ormris. Worth trying on MSVC, which is the other more likely place to fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140332/new/ https://reviews.llvm.org/D140332