[PATCH] D140562: [clang][ASTImporter] Improve import of InjectedClassNameType.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfeba03340cf3: [clang][ASTImporter] Improve import of InjectedClassNameType. (authored by balazske). Changed prior to commit:

[PATCH] D140562: [clang][ASTImporter] Improve import of InjectedClassNameType.

vabridgers accepted this revision. vabridgers added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140562/new/ https://reviews.llvm.org/D140562 ___ cfe-commits mailing list

[PATCH] D140562: [clang][ASTImporter] Improve import of InjectedClassNameType.

vabridgers added a comment. Hi @donat.nagy , no problem. That's ok for me. Best! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140562/new/ https://reviews.llvm.org/D140562 ___ cfe-commits mailing list

[PATCH] D140562: [clang][ASTImporter] Improve import of InjectedClassNameType.

donat.nagy added a comment. @vabridgers Thanks for testing these commits! As @balazske wrote on D144622 , I'd suggest handling the three commits (this one = D140562 , D144622 and D144273

[PATCH] D140562: [clang][ASTImporter] Improve import of InjectedClassNameType.

vabridgers added a comment. Patch D144622 should be integrated into this one when a reduced reproducer has been prepared as a unittest and/or LIT case. I verified the patch stack D144273 , D140562

[PATCH] D140562: [clang][ASTImporter] Improve import of InjectedClassNameType.

donat.nagy accepted this revision. donat.nagy added a comment. This revision is now accepted and ready to land. We reviewed this commit together with @gamesh411 and it looks good to us; we see that it eliminates a possibility where a type object could "acquire" multiple aliases. Repository:

[PATCH] D140562: [clang][ASTImporter] Improve import of InjectedClassNameType.

whisperity added a subscriber: vabridgers. whisperity added a comment. @vabridgers Please take a look at this, as per off-list discussion, in relation to D142822 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140562: [clang][ASTImporter] Improve import of InjectedClassNameType.

whisperity added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:4627 } else { -Type *newType = - new (*this, TypeAlignment) InjectedClassNameType(Decl, TST); +Type *newType = new (*this, TypeAlignment) InjectedClassNameType(Decl, TST);

[PATCH] D140562: [clang][ASTImporter] Improve import of InjectedClassNameType.

balazske updated this revision to Diff 492106. balazske added a comment. New patch after more thorough debugging. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140562/new/ https://reviews.llvm.org/D140562 Files: clang/lib/AST/ASTContext.cpp

[PATCH] D140562: [clang][ASTImporter] Improve import of InjectedClassNameType.

balazske planned changes to this revision. balazske added a comment. I plan to improve the fix and change the code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140562/new/ https://reviews.llvm.org/D140562

[PATCH] D140562: [clang][ASTImporter] Improve import of InjectedClassNameType.

balazske added a comment. This crash is produced if the test is run without the fix: [ RUN ] ParameterizedTests/ASTImporterOptionSpecificTestBase.ImportInjectedClassNameType/0 ASTTests: llvm-project/clang/lib/AST/ASTContext.cpp:4678: clang::QualType

[PATCH] D140562: [clang][ASTImporter] Improve import of InjectedClassNameType.

balazske created this revision. Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. balazske requested review of this revision. Herald added a project: clang. Herald added a