[PATCH] D140662: [NFC][Clang][RISCV] Reduce boilerplate when determining prototype for segment loads

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf2bec8702688: [NFC][Clang][RISCV] Reduce boilerplate when determining prototype for segment… (authored by eopXD). Repository: rG LLVM Github

[PATCH] D140662: [NFC][Clang][RISCV] Reduce boilerplate when determining prototype for segment loads

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. Go ahead, thanks for clean up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140662/new/ https://reviews.llvm.org/D140662

[PATCH] D140662: [NFC][Clang][RISCV] Reduce boilerplate when determining prototype for segment loads

eopXD updated this revision to Diff 485606. eopXD added a comment. Update comment section: remove mis-indented indents. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140662/new/ https://reviews.llvm.org/D140662 Files:

[PATCH] D140662: [NFC][Clang][RISCV] Reduce boilerplate when determining prototype for segment loads

eopXD updated this revision to Diff 485604. eopXD marked 2 inline comments as done. eopXD edited the summary of this revision. eopXD added a comment. Update comment section for segment load. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140662/new/

[PATCH] D140662: [NFC][Clang][RISCV] Reduce boilerplate when determining prototype for segment loads

khchen added a comment. LGTM. Thanks for clean up code! Comment at: clang/include/clang/Basic/riscv_vector.td:820 +(Address0, ..., Address{NF - 1}, mask, Ptr, VL) +(Address0, ..., Address{NF - 1}, mask, Maskedoff0, ..., Maskedoff{NF - 1}, + Ptr, VL) nit:

[PATCH] D140662: [NFC][Clang][RISCV] Reduce boilerplate when determining prototype for segment loads

eopXD updated this revision to Diff 485589. eopXD added a comment. Update code based on landing of D140678 . The motivation of this NFC patch comes from the struggle while I was tracing through them. I think the scattered comments of boilerplates with only

[PATCH] D140662: [NFC][Clang][RISCV] Reduce boilerplate when determining prototype for segment loads

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:862 + Value *VLOperand = Ops[PtrOperandIdx + 1]; + Operands.append(NF, PassThruOperand); + Operands.push_back(PtrOperand); This doesn't look right to me.

[PATCH] D140662: [NFC][Clang][RISCV] Reduce boilerplate when determining prototype for segment loads

khchen added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:847 + + // Intrinsic is in the form of below, + // Masked: (Vector0, ..., Vector{NF - 1}, Ptr, Mask, VL, Policy) After remove the builtins comment I don't have idea

[PATCH] D140662: [NFC][Clang][RISCV] Reduce boilerplate when determining prototype for segment loads

eopXD updated this revision to Diff 485270. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140662/new/ https://reviews.llvm.org/D140662 Files: clang/include/clang/Basic/riscv_vector.td Index:

[PATCH] D140662: [NFC][Clang][RISCV] Reduce boilerplate when determining prototype for segment loads

eopXD created this revision. eopXD added reviewers: craig.topper, kito-cheng, khchen. Herald added subscribers: sunshaoce, VincentWu, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,