[PATCH] D140867: [C++20] [Modules] Don't generate global ctors/dtors for variables which are available externally

ChuanqiXu added a comment. In D140867#4043763 , @Jake-Egan wrote: > In D140867#4042405 , @ChuanqiXu > wrote: > >> In D140867#4042351 , @Jake-Egan >> wrote: >>

[PATCH] D140867: [C++20] [Modules] Don't generate global ctors/dtors for variables which are available externally

Jake-Egan added a comment. In D140867#4042405 , @ChuanqiXu wrote: > In D140867#4042351 , @Jake-Egan > wrote: > >>> Would you like to take a double look? >> >> Yes, it still fails on the bot and on my local

[PATCH] D140867: [C++20] [Modules] Don't generate global ctors/dtors for variables which are available externally

ChuanqiXu added a comment. In D140867#4042351 , @Jake-Egan wrote: >> Would you like to take a double look? > > Yes, it still fails on the bot and on my local machine. I've added an XFAIL > to the test for now just to get the AIX bot green. Weird. Maybe

[PATCH] D140867: [C++20] [Modules] Don't generate global ctors/dtors for variables which are available externally

Jake-Egan added a comment. > Would you like to take a double look? Yes, it still fails on the bot and on my local machine. I've added an XFAIL to the test for now just to get the AIX bot green. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140867: [C++20] [Modules] Don't generate global ctors/dtors for variables which are available externally

ChuanqiXu added a comment. In D140867#4040590 , @Jake-Egan wrote: > In D140867#4038388 , @ChuanqiXu > wrote: > >> In D140867#4036239 , @Jake-Egan >> wrote: >> >>> Hi,

[PATCH] D140867: [C++20] [Modules] Don't generate global ctors/dtors for variables which are available externally

Jake-Egan added a comment. In D140867#4038388 , @ChuanqiXu wrote: > In D140867#4036239 , @Jake-Egan > wrote: > >> Hi, this test is failing on AIX, could you take a look please? >>

[PATCH] D140867: [C++20] [Modules] Don't generate global ctors/dtors for variables which are available externally

ChuanqiXu added a comment. In D140867#4036239 , @Jake-Egan wrote: > Hi, this test is failing on AIX, could you take a look please? > https://lab.llvm.org/buildbot/#/builders/214/builds/5242/steps/6/logs/FAIL__Clang__pr59765-modules-global-ctor-dtor_cppm

[PATCH] D140867: [C++20] [Modules] Don't generate global ctors/dtors for variables which are available externally

Jake-Egan added a comment. Hi, this test is failing on AIX, could you take a look please? https://lab.llvm.org/buildbot/#/builders/214/builds/5242/steps/6/logs/FAIL__Clang__pr59765-modules-global-ctor-dtor_cppm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140867: [C++20] [Modules] Don't generate global ctors/dtors for variables which are available externally

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG08f957808e5f: [C++20] [Modules] Dont generate global ctors/dtors for variables which are… (authored by ChuanqiXu). Herald added a project: clang.