[PATCH] D140876: [clang][C++20] Non-dependent access checks in requires expression.

2023-01-04 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 abandoned this revision. usaxena95 marked an inline comment as done. usaxena95 added a comment. Moving the changes to https://reviews.llvm.org/D140547 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140876/new/

[PATCH] D140876: [clang][C++20] Non-dependent access checks in requires expression.

2023-01-04 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 marked an inline comment as done. usaxena95 added a comment. In D140876#4023286 , @ilya-biryukov wrote: > Should access checks should happen in the context where `concept` is written > or where it's used? > If access-checking should happen

[PATCH] D140876: [clang][C++20] Non-dependent access checks in requires expression.

2023-01-03 Thread Roy Jacobson via Phabricator via cfe-commits
royjacobson added a comment. In D140876#4023286 , @ilya-biryukov wrote: > Should access checks should happen in the context where `concept` is written > or where it's used? Is there a standard wording around it? Unfortunately, only a standard wording

[PATCH] D140876: [clang][C++20] Non-dependent access checks in requires expression.

2023-01-03 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. Should access checks should happen in the context where `concept` is written or where it's used? Is there a standard wording around it? If access-checking should happen where concept is defined, having a hard error seems fine because of the wording you quoted: >

[PATCH] D140876: [clang][C++20] Non-dependent access checks in requires expression.

2023-01-03 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 updated this revision to Diff 485939. usaxena95 added a comment. More tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140876/new/ https://reviews.llvm.org/D140876 Files: clang/lib/Parse/ParseExprCXX.cpp

[PATCH] D140876: [clang][C++20] Non-dependent access checks in requires expression.

2023-01-03 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 created this revision. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Access to members in a non-dependent context would always yield an invalid expression. When it appears in a