[PATCH] D140927: [C++20][Modules] Fix named module import diagnostics.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG53a1314ed1b5: [C++20][Modules] Fix named module import diagnostics. (authored by iains). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D140927: [C++20][Modules] Fix named module import diagnostics.

iains updated this revision to Diff 490099. iains added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140927/new/ https://reviews.llvm.org/D140927 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/Parser.cpp clang/lib

[PATCH] D140927: [C++20][Modules] Fix named module import diagnostics.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140927/new/ https://reviews.llvm.org/D140927

[PATCH] D140927: [C++20][Modules] Fix named module import diagnostics.

ChuanqiXu added a comment. From the discussion in https://github.com/llvm/llvm-project/issues/59688, I feel you are correct. But let's wait for we get a clarification. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140927/new/ https://reviews.llvm

[PATCH] D140927: [C++20][Modules] Fix named module import diagnostics.

iains added a comment. In D140927#4024648 , @ChuanqiXu wrote: > [module.import]p1 says: > >> In a module unit, all module-import-declarations and export-declarations >> exporting module-import-declarations shall appear before all other >> declarations i

[PATCH] D140927: [C++20][Modules] Fix named module import diagnostics.

ChuanqiXu added a comment. [module.import]p1 says: > In a module unit, all module-import-declarations and export-declarations > exporting module-import-declarations shall appear before all other > declarations in the declaration-seq of the translation-unit and of the > private-module-fragment

[PATCH] D140927: [C++20][Modules] Fix named module import diagnostics.

iains created this revision. Herald added a subscriber: ChuanqiXu. Herald added a project: All. iains added reviewers: ChuanqiXu, dblaikie. iains added a subscriber: clang-modules. iains published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. We h