[PATCH] D140956: [clang-format] Add an option for breaking after C++11 attributes

owenpan added a comment. In D140956#4042990 , @krasimir wrote: >> Was it actually a regression or did this patch also fix a bug? It seems that >> the continuation indent before the & in your example is inconsistent with >> other similar function declara

[PATCH] D140956: [clang-format] Add an option for breaking after C++11 attributes

krasimir added a comment. > Was it actually a regression or did this patch also fix a bug? It seems that > the continuation indent before the & in your example is inconsistent with > other similar function declarations. Nice catch! I fully agree with you! Thank you for looking into this, sorry

[PATCH] D140956: [clang-format] Add an option for breaking after C++11 attributes

owenpan added a comment. In D140956#4038988 , @krasimir wrote: > It looks like this regressed the following example: > > % cat test.cc # formatted with older clang-format > a > &cc() {

[PATCH] D140956: [clang-format] Add an option for breaking after C++11 attributes

MyDeveloperDay added a comment. Before M=0 C=0 T=Unknown S=1 F=0 B=0 BK=0 P=0 Name=identifier L=25 PPK=2 FakeLParens= FakeRParens=0 II=0x1aa92d99900 Text='a' M=0 C=0 T=TemplateOpener S=0 F=0 B=0 BK=0 P=30 Name=less L=26 PPK=2 FakeLParens= FakeRParens=0 II=0x0 Text='<

[PATCH] D140956: [clang-format] Add an option for breaking after C++11 attributes

krasimir added a comment. It looks like this regressed the following example: % cat test.cc # formatted with older clang-format a &cc() { return 1; } % clang-format --version clang-format version 16.0.0 (https://gith

[PATCH] D140956: [clang-format] Add an option for breaking after C++11 attributes

MyDeveloperDay added a comment. In D140956#4028288 , @owenpan wrote: > In D140956#4028147 , > @MyDeveloperDay wrote: > >> If someone wants to extend this to include the old form, then that can be a >> completely

[PATCH] D140956: [clang-format] Add an option for breaking after C++11 attributes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa28f0747c2f3: [clang-format] Add an option for breaking after C++11 attributes (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D140956: [clang-format] Add an option for breaking after C++11 attributes

owenpan added a comment. In D140956#4028147 , @MyDeveloperDay wrote: > If someone wants to extend this to include the old form, then that can be a > completely different review. Better yet, use another tool like clang-tidy to replace the old with the n

[PATCH] D140956: [clang-format] Add an option for breaking after C++11 attributes

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. I'm good with that. I like small pieces of contained work and not open ended reviews that try to cover everything. If someone wants to extend this to include the old form, then that can be a completely different review. But t

[PATCH] D140956: [clang-format] Add an option for breaking after C++11 attributes

owenpan added a comment. In D140956#4025614 , @MyDeveloperDay wrote: > Should we care about other forms of attributes like `__stdcall` etc..? I > personally don't, just I assume from the tests this isn't covered (maybe just > add that limitation to the

[PATCH] D140956: [clang-format] Add an option for breaking after C++11 attributes

owenpan updated this revision to Diff 486445. owenpan retitled this revision from "[clang-format] Add an option for breaking after C++ attributes" to "[clang-format] Add an option for breaking after C++11 attributes". owenpan edited the summary of this revision. owenpan added a comment. - Delete