[PATCH] D141107: [clang-tidy] don't warn when returning the result for bugprone-standalone-empty

This revision was automatically updated to reflect the committed changes. Closed by commit rG7910ee7d8c6d: [clang-tidy] dont warn when returning the result for bugprone-standalone-empty (authored by v1nh1shungry, committed by cjdb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D141107: [clang-tidy] don't warn when returning the result for bugprone-standalone-empty

v1nh1shungry added a comment. Thank you for reviewing, @cjdb and @denik! If this patch is okay to land, could you please help me commit it? Thanks a lot! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141107/new/ https://reviews.llvm.org/D141107

[PATCH] D141107: [clang-tidy] don't warn when returning the result for bugprone-standalone-empty

denik accepted this revision. denik added a comment. Thanks @v1nh1shungry for the fix! The change and test cases look good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141107/new/ https://reviews.llvm.org/D141107

[PATCH] D141107: [clang-tidy] don't warn when returning the result for bugprone-standalone-empty

cjdb accepted this revision. cjdb added a comment. This revision is now accepted and ready to land. Excellent, let's wait for @denik's feedback before merging, but this LGTM. Thank you for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141107: [clang-tidy] don't warn when returning the result for bugprone-standalone-empty

v1nh1shungry marked an inline comment as done. v1nh1shungry added a comment. Thank you for reviewing and giving suggestions! @cjdb Hope there are enough test cases now, and not too many tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141107: [clang-tidy] don't warn when returning the result for bugprone-standalone-empty

v1nh1shungry updated this revision to Diff 487044. v1nh1shungry added a comment. add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141107/new/ https://reviews.llvm.org/D141107 Files:

[PATCH] D141107: [clang-tidy] don't warn when returning the result for bugprone-standalone-empty

cjdb added a comment. LGTM, thanks for fixing! Please be sure to have your commit message have `Fixes #59517` instead of a link to the issue, as this will close the bug upon merging. Comment at:

[PATCH] D141107: [clang-tidy] don't warn when returning the result for bugprone-standalone-empty

v1nh1shungry created this revision. v1nh1shungry added reviewers: cjdb, hokein. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. v1nh1shungry requested review of this revision. Herald added a project: clang-tools-extra. Herald