[PATCH] D141177: [Clang] Don't tell people to place _Alignas on a struct in diagnostics

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:5337-5346 + if (AL.isC11AlignasAttribute()) { +// Don't use the message with placement with _Alignas. +// This is because C doesnt let you use _Alignas on type declarations. +

[PATCH] D141177: [Clang] Don't tell people to place _Alignas on a struct in diagnostics

theo-lw updated this revision to Diff 552181. theo-lw added a comment. Ran clang-format on this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141177/new/ https://reviews.llvm.org/D141177 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/AttributeCommonInfo.h

[PATCH] D141177: [Clang] Don't tell people to place _Alignas on a struct in diagnostics

theo-lw updated this revision to Diff 552061. theo-lw added a comment. Herald added a subscriber: jdoerfert. Rebased on the main branch & addressed comments. Added additional test case for C++ alignas. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141177/new/

[PATCH] D141177: [Clang] Don't tell people to place _Alignas on a struct in diagnostics

aaron.ballman added a comment. In D141177#4592361 , @theo-lw wrote: > In D141177#4592158 , @aaron.ballman > wrote: > >> @theo-lw -- are you planning to continue working on this review? (It's okay >> if you're

[PATCH] D141177: [Clang] Don't tell people to place _Alignas on a struct in diagnostics

theo-lw added a comment. In D141177#4592158 , @aaron.ballman wrote: > @theo-lw -- are you planning to continue working on this review? (It's okay > if you're not, I'm more wondering if I should remove you as the assignee on >

[PATCH] D141177: [Clang] Don't tell people to place _Alignas on a struct in diagnostics

aaron.ballman added a comment. @theo-lw -- are you planning to continue working on this review? (It's okay if you're not, I'm more wondering if I should remove you as the assignee on https://github.com/llvm/llvm-project/issues/58637) CHANGES SINCE LAST ACTION

[PATCH] D141177: [Clang] Don't tell people to place _Alignas on a struct in diagnostics

aaron.ballman added a comment. Thank you for the fix, please be sure to add a release note for the fix as well. Also, I'd like to see some additional C++ test coverage for: `alignas(int) struct S {};` to demonstrate we still suggest moving the keyword in that case. Comment

[PATCH] D141177: [Clang] Don't tell people to place _Alignas on a struct in diagnostics

theo-lw updated this revision to Diff 487119. theo-lw added a comment. Didn't realize this test was failing so I've updated it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141177/new/ https://reviews.llvm.org/D141177 Files: clang/lib/Sema/SemaDecl.cpp clang/test/C/drs/dr4xx.c

[PATCH] D141177: [Clang] Don't tell people to place _Alignas on a struct in diagnostics

theo-lw updated this revision to Diff 487103. theo-lw added a comment. Accidentally deleted a line causing this to not compile :( CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141177/new/ https://reviews.llvm.org/D141177 Files: clang/lib/Sema/SemaDecl.cpp

[PATCH] D141177: [Clang] Don't tell people to place _Alignas on a struct in diagnostics

theo-lw created this revision. theo-lw added a reviewer: aaron.ballman. Herald added a project: All. theo-lw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This changes the diagnostic for _Alignas so it no longer tells people to place