[PATCH] D141192: [Clang] Fix warnings on bad shifts.

budimirarandjelovicsyrmia added a comment. Created Pull Request . Addressed all coments except ones addressing target architecture and considering emitting error instead of warning. CHANGES SINCE LAST ACTION

[PATCH] D141192: [Clang] Fix warnings on bad shifts.

aaron.ballman added a comment. In D141192#4647977 , @budimirarandjelovicsyrmia wrote: > Ping. Given the lack of response, I think it's safe to assume this patch has been abandoned by the author. I'd recommend starting a new patch review for it on

[PATCH] D141192: [Clang] Fix warnings on bad shifts.

budimirarandjelovicsyrmia added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141192/new/ https://reviews.llvm.org/D141192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D141192: [Clang] Fix warnings on bad shifts.

budimirarandjelovicsyrmia added a comment. @chestnykh Are you still working on this issue? If not, I'm interested to continue working on issue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141192/new/ https://reviews.llvm.org/D141192 ___

[PATCH] D141192: [Clang] Fix warnings on bad shifts.

aaron.ballman added a comment. Sorry for the delay in reviewing, I was out for standards meetings last week and couldn't get to this one. For future patches, can you be sure to upload them with more diff context (`-U` is what I usually use). You should also add a release note for the fix.

[PATCH] D141192: [Clang] Fix warnings on bad shifts.

chestnykh added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141192/new/ https://reviews.llvm.org/D141192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D141192: [Clang] Fix warnings on bad shifts.

chestnykh added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141192/new/ https://reviews.llvm.org/D141192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D141192: [Clang] Fix warnings on bad shifts.

chestnykh added a comment. Ping, can someone review my changes? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141192/new/ https://reviews.llvm.org/D141192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D141192: [Clang] Fix warnings on bad shifts.

chestnykh updated this revision to Diff 487200. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141192/new/ https://reviews.llvm.org/D141192 Files: clang/lib/AST/ExprConstant.cpp clang/lib/Sema/SemaExpr.cpp clang/test/AST/Interp/shifts.cpp clang/test/C/drs/dr0xx.c

[PATCH] D141192: [Clang] Fix warnings on bad shifts.

chestnykh updated this revision to Diff 487183. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141192/new/ https://reviews.llvm.org/D141192 Files: clang/lib/AST/ExprConstant.cpp clang/lib/Sema/SemaExpr.cpp clang/test/AST/Interp/shifts.cpp clang/test/C/drs/dr0xx.c

[PATCH] D141192: [Clang] Fix warnings on bad shifts.

chestnykh added a comment. In D141192#4033962 , @tbaeder wrote: > In D141192#4033591 , @shafik wrote: > >> So it looks like in `handleIntIntBinOp` we do hit this code: >> >> unsigned SA = (unsigned)

[PATCH] D141192: [Clang] Fix warnings on bad shifts.

chestnykh added a comment. I've modified `handleIntIntBinOp` so now it emits message about bad shift value. `DiagnoseBadShiftValues` changes are also needed because `handleIntIntBinOp` cant properly cover for example the case we are not in c++11 mode. CHANGES SINCE LAST ACTION

[PATCH] D141192: [Clang] Fix warnings on bad shifts.

chestnykh updated this revision to Diff 487174. chestnykh retitled this revision from "[Clang] Add warnings on bad shifts inside enums." to "[Clang] Fix warnings on bad shifts.". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141192/new/ https://reviews.llvm.org/D141192 Files: