[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd14e7ee3d17c: [clang-format] Add -j to clang-format-diff to speed up formatting (authored by seanptmaher, committed by owenpan). Repository: rG

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

seanptmaher added a comment. Hey, Sure. The name is Sean Maher and the email is s...@chromium.org Thanks for your help. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141230/new/ https://reviews.llvm.org/D141230

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

owenpan added a comment. In D141230#4054768 , @seanptmaher wrote: > I can't actually commit this -- could one of you? Or has it already been > done? I remember reading that someone had to manually push the patch upstream. Can we have the name and

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

seanptmaher added a comment. Hey, bump on this. Still waiting on the commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141230/new/ https://reviews.llvm.org/D141230 ___ cfe-commits mailing list

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

seanptmaher added a comment. I can't actually commit this -- could one of you? Or has it already been done? I remember reading that someone had to manually push the patch upstream. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141230/new/

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. I can see why you have the desire for something that takes 22 seconds and not 16 mins! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

seanptmaher added a comment. Thanks a lot for the review, by the way. I realize the patch wasn't up to snuff initially, but glad to get it in order with your help. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141230/new/

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

seanptmaher updated this revision to Diff 489086. seanptmaher added a comment. No need to include os anymore, I'm not checking number of cores Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141230/new/ https://reviews.llvm.org/D141230 Files:

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

seanptmaher added a comment. It's slightly hard to test this because it involves making a huge diff of a git repo. If you're willing to jump through the hoops of cloning chromium (honestly, this is a pain in the ass. It's too much hard drive space and you've got to install depot_tools. If you

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

seanptmaher updated this revision to Diff 489084. seanptmaher added a comment. Fix bug in -j implementation where proper waiting wasn't happening Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141230/new/ https://reviews.llvm.org/D141230 Files:

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

owenpan added a comment. In D141230#4048069 , @seanptmaher wrote: > The use case I was using this with was running diff formatting of very large > diffs (automated mass refactors changing thousands of files) on the chromium > codebase -- I'm not sure

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

seanptmaher updated this revision to Diff 488708. seanptmaher added a comment. fix the formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141230/new/ https://reviews.llvm.org/D141230 Files: clang/tools/clang-format/clang-format-diff.py

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

seanptmaher added a comment. Yeah, the jobs flag is a much better implementation. Thanks for the comments. I've implemented that. I was indeed making the assumption that this is all that's running, etc. as you mentioned. The use case I was using this with was running diff formatting of very

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

seanptmaher updated this revision to Diff 488706. seanptmaher added a comment. Add jobs flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141230/new/ https://reviews.llvm.org/D141230 Files: clang/tools/clang-format/clang-format-diff.py Index:

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. On my laptop running import os; import multiprocessing def main(): num = len(os.sched_getaffinity(0)) numcpu = multiprocessing.cpu_count()

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

owenpan added a comment. Can you add an option e.g. `-j N` where `N` is a positive integer and defaults to 1? Also, can you include a use case in which we can see the ~10x improvement on runtime? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

seanptmaher updated this revision to Diff 487407. seanptmaher added a comment. Possibly fix the patchset? Sorry I've never used phabricator berfore. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141230/new/ https://reviews.llvm.org/D141230 Files:

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. You've lost the first part of the patch in this latest diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141230/new/

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

seanptmaher updated this revision to Diff 487243. seanptmaher added a comment. Update python formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141230/new/ https://reviews.llvm.org/D141230 Files:

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

seanptmaher created this revision. seanptmaher added a reviewer: MyDeveloperDay. Herald added a project: All. seanptmaher requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch changes the implementation of clang-format-diff.py to