[PATCH] D141297: [OpenCL] Allow undefining header-only features

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa60b8f468119: [OpenCL] Allow undefining header-only features (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141297: [OpenCL] Allow undefining header-only features

Anastasia added a comment. In D141297#4047148 , @svenvh wrote: > In D141297#4043122 , @Anastasia > wrote: > >> Btw I wonder if in the future we could add some error or warning in case >> someone uses the same ap

[PATCH] D141297: [OpenCL] Allow undefining header-only features

svenvh added a comment. In D141297#4043122 , @Anastasia wrote: > Btw I wonder if in the future we could add some error or warning in case > someone uses the same approach for frontend specific features, i.e. > > #ifdef __undef___opencl_c_generic_addres

[PATCH] D141297: [OpenCL] Allow undefining header-only features

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM, thanks! Btw I wonder if in the future we could add some error or warning in case someone uses the same approach for frontend specific features, i.e. #ifdef __undef___opencl_c_ge

[PATCH] D141297: [OpenCL] Allow undefining header-only features

svenvh created this revision. svenvh added reviewers: Anastasia, FMarno. Herald added subscribers: Naghasan, ldrumm, yaxunl. Herald added a project: All. svenvh requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `opencl-c-base.h` always define