[PATCH] D141572: [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf90074274673: [C++] [Coroutines] Deprecates the -fcoroutines-ts flag (authored by ChuanqiXu). Herald added a project: libc++. Herald added a

[PATCH] D141572: [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141572/new/ https://reviews.llvm.org/D141572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D141572: [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag

ChuanqiXu updated this revision to Diff 489665. ChuanqiXu added a comment. Address comments and refine the wording from "use `-std=c++20`" to "use `-std=c++20` or higher". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141572/new/ https://reviews.llvm.org/D141572 Files:

[PATCH] D141572: [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag

philnik accepted this revision. philnik added a comment. This revision is now accepted and ready to land. LGTM from the libc++ side of things % nit. I think @aaron.ballman should take another look at the Clang changes. Comment at: libcxx/utils/generate_header_tests.py:22 +

[PATCH] D141572: [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag

ChuanqiXu updated this revision to Diff 489437. ChuanqiXu added a comment. Move the release note to `Deprecated Compiler Flags` section. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141572/new/ https://reviews.llvm.org/D141572 Files: clang/docs/ReleaseNotes.rst

[PATCH] D141572: [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag

ChuanqiXu added a reviewer: philnik. ChuanqiXu added a comment. Now it looks like the failure are not related to the patch. Although there are some clang-format related failures, the related changes are generated automatically and I roughly remember libcxx don't use libcxx. @philnik would you

[PATCH] D141572: [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag

ChuanqiXu added a comment. In D141572#4050758 , @philnik wrote: > In D141572#4050492 , @ChuanqiXu > wrote: > >> @philnik when I run `ninja libcxx-generate-files` locally, it says `ninja: >> error: unknown

[PATCH] D141572: [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag

ChuanqiXu updated this revision to Diff 489412. ChuanqiXu added a comment. Update the header tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141572/new/ https://reviews.llvm.org/D141572 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D141572: [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag

philnik added a comment. In D141572#4050492 , @ChuanqiXu wrote: > @philnik when I run `ninja libcxx-generate-files` locally, it says `ninja: > error: unknown target 'libcxx-generate-files'`. The following off is my > configuring command: > > cmake -G

[PATCH] D141572: [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag

ChuanqiXu added a comment. @philnik when I run `ninja libcxx-generate-files` locally, it says `ninja: error: unknown target 'libcxx-generate-files'`. The following off is my configuring command: cmake -G Ninja -S llvm -B build_libcxx_modules -DLLVM_ENABLE_PROJECTS="clang"

[PATCH] D141572: [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag

ChuanqiXu updated this revision to Diff 488873. ChuanqiXu added a comment. Herald added a subscriber: arichardson. After failed to reproduce the error locally, try to follow the instructions from @philnik to see if the CI-Bot will break. CHANGES SINCE LAST ACTION

[PATCH] D141572: [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag

philnik added a comment. In D141572#4047428 , @aaron.ballman wrote: > Thank you for working on this! I think the Debian CI failure is unrelated, > but the libc++ one looks plausibly related: > > >

[PATCH] D141572: [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag

aaron.ballman added a reviewer: libc++. aaron.ballman added a comment. Thank you for working on this! I think the Debian CI failure is unrelated, but the libc++ one looks plausibly related:

[PATCH] D141572: [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag

ChuanqiXu created this revision. ChuanqiXu added reviewers: aaron.ballman, ldionne. ChuanqiXu added a project: clang-language-wg. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. According to