[PATCH] D141671: Move around structs and definitions to prevent incomplete types.

massberg updated this revision to Diff 488976. massberg added a comment. Clean up code and only mode definitions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141671/new/ https://reviews.llvm.org/D141671 Files:

[PATCH] D141671: Move around structs and definitions to prevent incomplete types.

massberg added a comment. > Having as few code in headers as possible is the general style guide in LLVM, > so I'd rather err towards that and put definitions out-of-line as much as > possible. Therefore if we can getaway by just moving definitions out-of-line, > while keeping rest of the

[PATCH] D141671: Move around structs and definitions to prevent incomplete types.

kadircet added a comment. In D141671#4050928 , @ilya-biryukov wrote: > There is potentially a way to move less code by keeping all declarations at > place and only moving bodies of definitions of constructors and destructors > to the `.cpp` file. >

[PATCH] D141671: Move around structs and definitions to prevent incomplete types.

ilya-biryukov added a reviewer: kadircet. ilya-biryukov added a subscriber: kadircet. ilya-biryukov added a comment. There is potentially a way to move less code by keeping all declarations at place and only moving bodies of definitions of constructors and destructors to the `.cpp` file. Not

[PATCH] D141671: Move around structs and definitions to prevent incomplete types.

massberg created this revision. massberg added a reviewer: ilya-biryukov. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. C++20 is more strict when erroring out due to incomplete types.