[PATCH] D141671: Move definitions to prevent incomplete types.

2023-01-13 Thread Jens Massberg via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf88c6b9166f8: Move definitions to prevent incomplete types. (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D141671: Move definitions to prevent incomplete types.

2023-01-13 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov accepted this revision. ilya-biryukov added a comment. LGTM! Looks much cleaner now, BTW. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141671/new/ https://reviews.llvm.org/D141671 ___

[PATCH] D141671: Move definitions to prevent incomplete types.

2023-01-13 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LGTM! (btw, i know it's too late already, but in theory clangd has a code action called move definition out-of-line, could help with such refactorings in the future, if you didn't

[PATCH] D141671: Move definitions to prevent incomplete types.

2023-01-13 Thread Jens Massberg via Phabricator via cfe-commits
massberg added a comment. I have updated the code. It turned out that much less code has to be moved than I initially thought. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141671/new/ https://reviews.llvm.org/D141671