This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf88c6b9166f8: Move definitions to prevent incomplete types.
(authored by massberg).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
LGTM! Looks much cleaner now, BTW.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141671/new/
https://reviews.llvm.org/D141671
___
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, LGTM! (btw, i know it's too late already, but in theory clangd has a
code action called move definition out-of-line, could help with such
refactorings in the future, if you didn't
massberg added a comment.
I have updated the code. It turned out that much less code has to be moved than
I initially thought. :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141671/new/
https://reviews.llvm.org/D141671