[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

This revision was automatically updated to reflect the committed changes. Closed by commit rG9795aa042a84: [RISCV] Support vector crypto extension ISA string and assembly (authored by 4vtomat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141672/new/ https://reviews.llvm.org/D141672

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

4vtomat updated this revision to Diff 506894. 4vtomat added a comment. Resolved Craig's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141672/new/ https://reviews.llvm.org/D141672 Files: clang/test/Preprocessor/riscv-target-features.c

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

craig.topper added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:893 +errc::invalid_argument, +"'zvknhb' requires 'zve64x' extension to also be specified"); + For consistency with the Zvk* error, use `"'zvknhb' requires 'v' or

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

reames added a comment. FYI, zvkb was discussed at the Architectural Review Committee this week and they've asked for some significant changes and expansions. See the notes shared here: https://lists.riscv.org/g/tech-unprivileged/message/450 I actively do not think we need to wait on landing

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

4vtomat updated this revision to Diff 505112. 4vtomat added a comment. Resolved Craig's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141672/new/ https://reviews.llvm.org/D141672 Files: clang/test/Preprocessor/riscv-target-features.c

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

craig.topper added inline comments. Herald added a subscriber: jobnoorman. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:820 +errc::invalid_argument, +"zvk* requires v or zve* extension to also be specified"); + Put single quotes around extension

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

4vtomat updated this revision to Diff 504034. 4vtomat added a comment. Resolved Craig's comments and rename *zvkns* files to *zvkned*. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141672/new/ https://reviews.llvm.org/D141672 Files:

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

asb added a comment. In D141672#4177044 , @craig.topper wrote: > I guess the question is whether we should update to the most recent now or > land this first. I think updating to the most recent would make sense. Review bandwidth is limited, and it

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

craig.topper added a comment. @reames and I recently talked and we agreed that vector crypto is far enough along that we'd like to get something committed to LLVM in experimental state. We can do iterative refinement if the spec continues to change. I guess the question is whether we should

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

4vtomat updated this revision to Diff 498253. 4vtomat marked 2 inline comments as done. 4vtomat added a comment. Update to v20230206 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141672/new/ https://reviews.llvm.org/D141672 Files:

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

craig.topper added a comment. In D141672#4100940 , @reames wrote: > This was brought up in today's RISCV sync call; I want to summarize the major > points of discussion. > > This patch is now behind the current most recent revision on the >

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

reames added a comment. This was brought up in today's RISCV sync call; I want to summarize the major points of discussion. This patch is now behind the current most recent revision on the vector-crypto spec.

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

4vtomat updated this revision to Diff 493826. 4vtomat added a comment. NFC, some indentation fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141672/new/ https://reviews.llvm.org/D141672 Files: clang/test/Preprocessor/riscv-target-features.c

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

craig.topper added inline comments. Herald added a subscriber: luke. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:765 + if ((Exts.count("zvkb") || Exts.count("zvkg") || Exts.count("zvknha") || Exts.count("zvkns") || + Exts.count("zvksed") || Exts.count("zvksh")) &&

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

4vtomat added a comment. Since there's some accidentally pushed code. The old revision is moved to this one, sorry.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141672/new/ https://reviews.llvm.org/D141672

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

4vtomat created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217,