[PATCH] D141681: [clang][Interp] Fix parameter map when re-visiting function

2023-03-31 Thread Timm Bäder via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfce093ccb1c5: [clang][Interp] Fix parameter map when re-visiting function (authored by tbaeder). Changed prior to commit:

[PATCH] D141681: [clang][Interp] Fix parameter map when re-visiting function

2023-01-13 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeEmitter.cpp:57 +ParamDescriptors.insert({ParamOffset, {Ty, Desc}}); +Params.insert({PD, ParamOffset}); +ParamOffset += align(primSize(Ty)); shafik wrote: > Where is `Params`

[PATCH] D141681: [clang][Interp] Fix parameter map when re-visiting function

2023-01-13 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/AST/Interp/ByteCodeEmitter.cpp:57 +ParamDescriptors.insert({ParamOffset, {Ty, Desc}}); +Params.insert({PD, ParamOffset}); +ParamOffset

[PATCH] D141681: [clang][Interp] Fix parameter map when re-visiting function

2023-01-13 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. 'Params' is a member of the ByteCodeEmitter. We