This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGfce093ccb1c5: [clang][Interp] Fix parameter map when
re-visiting function (authored by tbaeder).
Changed prior to commit:
tbaeder added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeEmitter.cpp:57
+ParamDescriptors.insert({ParamOffset, {Ty, Desc}});
+Params.insert({PD, ParamOffset});
+ParamOffset += align(primSize(Ty));
shafik wrote:
> Where is `Params`
shafik accepted this revision.
shafik added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang/lib/AST/Interp/ByteCodeEmitter.cpp:57
+ParamDescriptors.insert({ParamOffset, {Ty, Desc}});
+Params.insert({PD, ParamOffset});
+ParamOffset
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
'Params' is a member of the ByteCodeEmitter. We