[PATCH] D141705: [HLSL] [Dirver] add dxv as a VerifyDebug Job

python3kgae added a comment. In D141705#4059162 , @beanz wrote: > Re-using the `VerifyDebug` action really doesn't make sense. That's not what > the DXIL validator does, and it will be a source of confusion forever. Added BinaryAnalyzeJobClass.

[PATCH] D141705: [HLSL] [Dirver] add dxv as a VerifyDebug Job

python3kgae updated this revision to Diff 489935. python3kgae marked 2 inline comments as done. python3kgae added a comment. Add BinaryAnalyzeJobClass. Add -Vd to disable validation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141705/new/

[PATCH] D141705: [HLSL] [Dirver] add dxv as a VerifyDebug Job

beanz added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4215 + // Call validator for dxc. + if (IsDXCMode()) { +Action *LastAction = Actions.back(); Shouldn't the validator only run if we are targeting DXIL? Also we should probably add the

[PATCH] D141705: [HLSL] [Dirver] add dxv as a VerifyDebug Job

beanz added a comment. Re-using the `VerifyDebug` action really doesn't make sense. That's not what the DXIL validator does, and it will be a source of confusion forever. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141705/new/

[PATCH] D141705: [HLSL] [Dirver] add dxv as a VerifyDebug Job

python3kgae created this revision. python3kgae added reviewers: beanz, pow2clk, bogner, bob80905. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. New