phosek added inline comments.
Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:73
+
+if(WIN32 OR (LINUX AND WINDOWS_SDK_DIR))
+#if(WINDOWS_SDK_DIR)
I'd drop this part altogether, let's build these anytime when `WINDOWS_SDK_DIR`
is set.
haowei updated this revision to Diff 489177.
haowei added a comment.
Correct C, CXX flag issue.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141738/new/
https://reviews.llvm.org/D141738
Files:
clang/cmake/caches/Fuchsia-stage2.cmake
haowei created this revision.
haowei added a reviewer: phosek.
Herald added a subscriber: abrachet.
Herald added a project: All.
haowei requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
Work in progress.
Initial work on
