[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rG5fcdab04c250: [Fuchsia] Build windows runtimes using cross compilation on Linux (authored by haowei). Changed prior to commit: https://reviews.llvm.org/D141738?vs=493766=495281#toc Repository: rG

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

phosek accepted this revision. phosek added a comment. LGTM Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:95 +# and remove these libpath flags. +-libpath:"${LLVM_WINSYSROOT}/VC/Tools/MSVC/14.34.31933/lib/x64" +

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

haowei added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:95 +# and remove these libpath flags. +-libpath:"${LLVM_WINSYSROOT}/VC/Tools/MSVC/14.34.31933/lib/x64" +

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

phosek added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:95 +# and remove these libpath flags. +-libpath:"${LLVM_WINSYSROOT}/VC/Tools/MSVC/14.34.31933/lib/x64" +

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

haowei updated this revision to Diff 493766. haowei added a comment. Correct dependency issues on llvm-mt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141738/new/ https://reviews.llvm.org/D141738 Files: clang/cmake/caches/Fuchsia-stage2.cmake

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

phosek added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:95 +# and remove these libpath flags. +-libpath:"${LLVM_WINSYSROOT}/VC/Tools/MSVC/14.34.31933/lib/x64" +

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

haowei added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:95 +# and remove these libpath flags. +-libpath:"${LLVM_WINSYSROOT}/VC/Tools/MSVC/14.34.31933/lib/x64" +

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

thakis added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:95 +# and remove these libpath flags. +-libpath:"${LLVM_WINSYSROOT}/VC/Tools/MSVC/14.34.31933/lib/x64" +

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG20bb7658f53b: [Fuchsia] Build windows runtimes using cross compilation on Linux (authored by haowei). Changed prior to commit:

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

haowei added a comment. Thanks for the review. I will land the change once Fuchsia clang builders are green. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141738/new/ https://reviews.llvm.org/D141738

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141738/new/ https://reviews.llvm.org/D141738

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

haowei updated this revision to Diff 490994. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141738/new/ https://reviews.llvm.org/D141738 Files: clang/cmake/caches/Fuchsia-stage2.cmake llvm/cmake/modules/LLVMExternalProjectUtils.cmake Index:

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

phosek added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:79 + if (LLVM_WINSYSROOT) +set(CLANG_WINDOWS_CROSS_FLAGS + -Xclang I think we'll want to use these flags even when not cross-compiling so I'd change the name to reflect

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

haowei updated this revision to Diff 490921. haowei added a comment. Correct an issue llvm-rc and llvm-mt are not part of `TOOLCHAIN_TOOLS` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141738/new/ https://reviews.llvm.org/D141738 Files:

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

haowei marked 2 inline comments as done. haowei added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:73 + +if(WIN32 OR (LINUX AND WINDOWS_SDK_DIR)) +#if(WINDOWS_SDK_DIR) phosek wrote: > I'd drop this part altogether, let's build these

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

haowei updated this revision to Diff 490679. haowei retitled this revision from "[WIP] Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain" to "Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang