[PATCH] D141787: [clang-tidy] fix a false positive of `modernize-concat-nested-namespaces`

v1nh1shungry added a comment. Ping? @njames93 Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/concat-nested-namespaces.cpp:173 +namespace n48 { +// CHECK-MESSAGES-DAG: :[[@LINE-2]]:1: warning: nested namespaces can be concatenated [modernize-concat-nested-nam

[PATCH] D141787: [clang-tidy] fix a false positive of `modernize-concat-nested-namespaces`

v1nh1shungry added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/concat-nested-namespaces.cpp:173 +namespace n48 { +// CHECK-MESSAGES-DAG: :[[@LINE-2]]:1: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces] +//

[PATCH] D141787: [clang-tidy] fix a false positive of `modernize-concat-nested-namespaces`

njames93 requested changes to this revision. njames93 added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/concat-nested-namespaces.cpp:173 +namespace n48 { +// CHECK-MESSAGES-DAG: :[[@LINE-2]]:1:

[PATCH] D141787: [clang-tidy] fix a false positive of `modernize-concat-nested-namespaces`

v1nh1shungry added a comment. In D141787#4054514 , @v1nh1shungry wrote: > This patch doesn't handle situations like: > > namespace a { > namespace b { > #define FOO > namespace c { > } > } > } It did. I must be mad :( Repository: rG LL

[PATCH] D141787: [clang-tidy] fix a false positive of `modernize-concat-nested-namespaces`

v1nh1shungry updated this revision to Diff 489350. v1nh1shungry added a comment. add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141787/new/ https://reviews.llvm.org/D141787 Files: clang-tools-extra/clang-tidy/modernize/ConcatNestedName

[PATCH] D141787: [clang-tidy] fix a false positive of `modernize-concat-nested-namespaces`

v1nh1shungry planned changes to this revision. v1nh1shungry added a comment. This patch doesn't handle situations like: namespace a { namespace b { #define FOO namespace c { } } } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141787/n

[PATCH] D141787: [clang-tidy] fix a false positive of `modernize-concat-nested-namespaces`

v1nh1shungry created this revision. v1nh1shungry added reviewers: carlosgalvezp, Eugene.Zelenko. Herald added a subscriber: xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. v1nh1shungry requested review of this revision. Herald added a project: clang-tools-extra. Herald ad