[PATCH] D141826: [clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

2023-03-08 Thread Andrey Ali Khan Bolshakov via Phabricator via cfe-commits
bolshakov-a added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:6842 case TemplateArgument::Integral: return TemplateArgument(Arg, getCanonicalType(Arg.getIntegralType())); @Michael137, hasn't `IsDefaulted` parameter forgotten here?

[PATCH] D141826: [clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

2023-01-26 Thread Michael Buch via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8b4279b66fc2: [clang][TemplateBase] Add IsDefaulted bit to TemplateArgument (authored by Michael137). Repository: rG LLVM Github Monorepo

[PATCH] D141826: [clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

2023-01-25 Thread Michael Buch via Phabricator via cfe-commits
Michael137 updated this revision to Diff 492306. Michael137 added a comment. - Remove redundant constructor call change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141826/new/ https://reviews.llvm.org/D141826 Files:

[PATCH] D141826: [clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

2023-01-25 Thread Michael Buch via Phabricator via cfe-commits
Michael137 added a comment. Latest diff now sets the `IsDefaulted` flag from `Sema::CheckTemplateArgumentList`, which is the best point I could find for creation of `TemplateArgument` which are fed into the various specialization decls (and later on the `TypePrinter`). The review description