yaxunl added inline comments.
Herald added subscribers: jplehr, sunshaoce.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8090
if (Triple.isAMDGPU())
-handleAMDGPUCodeObjectVersionOptions(D, Args, CmdArgs, /*IsCC1As=*/true);
+handleAMDGPUCodeObjectVersionOptions(D,
yaxunl added a comment.
Is this patch really necessary? `-mcode-object-version=` option does not go
through any translation in derived args. If it is in derived args, it should
also be in the original args. HIPAMD toolchain just uses the original driver
args. Why OpenMP toolchain needs to use
saiislam marked an inline comment as done.
saiislam added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7116
if (Triple.isAMDGPU()) {
-handleAMDGPUCodeObjectVersionOptions(D, Args, CmdArgs);
+handleAMDGPUCodeObjectVersionOptions(D, C.getArgs(),
saiislam updated this revision to Diff 490204.
saiislam added a comment.
Removed the unnecessary call to getArgs() and added test cases.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142022/new/
https://reviews.llvm.org/D142022
Files:
yaxunl added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7116
if (Triple.isAMDGPU()) {
-handleAMDGPUCodeObjectVersionOptions(D, Args, CmdArgs);
+handleAMDGPUCodeObjectVersionOptions(D, C.getArgs(), CmdArgs);
why do you need to
saiislam created this revision.
saiislam added reviewers: jhuber6, yaxunl.
Herald added subscribers: kosarev, kerbowa, guansong, tpr, jvesely.
Herald added a project: All.
saiislam requested review of this revision.
Herald added subscribers: cfe-commits, sstefan1, MaskRay.
Herald added a reviewer:
