[PATCH] D142437: [clang] Add the check of membership in decltype for the issue #58674

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG01adf96ebc86: [clang] Add the check of membership in decltype for the issue #58674 (authored by lime). Repository: rG LLVM Github Monorepo

[PATCH] D142437: [clang] Add the check of membership in decltype for the issue #58674

lime updated this revision to Diff 493058. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142437/new/ https://reviews.llvm.org/D142437 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/DeclCXX.h clang/lib/AST/CXXInheritance.cpp clang/lib/Sema/SemaExpr.cpp

[PATCH] D142437: [clang] Add the check of membership in decltype for the issue #58674

lime updated this revision to Diff 493057. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142437/new/ https://reviews.llvm.org/D142437 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/DeclCXX.h clang/lib/AST/CXXInheritance.cpp clang/lib/Sema/SemaExpr.cpp

[PATCH] D142437: [clang] Add the check of membership in decltype for the issue #58674

lime updated this revision to Diff 493055. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142437/new/ https://reviews.llvm.org/D142437 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/DeclCXX.h clang/lib/AST/CXXInheritance.cpp clang/lib/Sema/SemaExpr.cpp

[PATCH] D142437: [clang] Add the check of membership in decltype for the issue #58674

lime updated this revision to Diff 491981. lime added a comment. Updated as suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142437/new/ https://reviews.llvm.org/D142437 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/DeclCXX.h clang/lib/AST/CXXInheritance.cpp

[PATCH] D142437: [clang] Add the check of membership in decltype for the issue #58674

shafik added a comment. FYI, I was looking at similar issues over the weekend and put up this PR: https://reviews.llvm.org/D142490 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142437/new/ https://reviews.llvm.org/D142437 ___ cfe-commits

[PATCH] D142437: [clang] Add the check of membership in decltype for the issue #58674

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. 1 nit, otherwise I don't have concerns. Comment at: clang/lib/Sema/SemaExpr.cpp:2717 +if ((MightBeImplicitMember = ThisClass->Equals(Class) || +

[PATCH] D142437: [clang] Add the check of membership in decltype for the issue #58674

lime updated this revision to Diff 491717. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142437/new/ https://reviews.llvm.org/D142437 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/DeclCXX.h clang/lib/AST/CXXInheritance.cpp clang/lib/Sema/SemaExpr.cpp

[PATCH] D142437: [clang] Add the check of membership in decltype for the issue #58674

lime created this revision. lime added reviewers: aaron.ballman, erichkeane, cor3ntin, clang-language-wg. lime added a project: clang. Herald added a subscriber: yaxunl. Herald added a project: All. lime requested review of this revision. Herald added a subscriber: cfe-commits. D137531