[PATCH] D142507: [AMDGPU] Split dot7 feature

rampitec added a comment. In D142507#4127505 , @b-sumner wrote: >> My current understanding is the c-p will go into already forked clang-16, >> but not to rocm 5.4. So rocm device-libs will be accompanied by the older >> clang-16 w/o this and stay

[PATCH] D142507: [AMDGPU] Split dot7 feature

b-sumner added a comment. > My current understanding is the c-p will go into already forked clang-16, but > not to rocm 5.4. So rocm device-libs will be accompanied by the older > clang-16 w/o this and stay compatible. Someone building from scratch will use > latest clang-16 and staging

[PATCH] D142507: [AMDGPU] Split dot7 feature

rampitec added a comment. In D142507#4127421 , @b-sumner wrote: > I have no objection to backporting this, but it may need to be accompanied > with a device-libs patch, and I don't know where that patch would be checked > in. The ROCm-Device-Libs in

[PATCH] D142507: [AMDGPU] Split dot7 feature

b-sumner added a comment. In D142507#4127382 , @rampitec wrote: > In D142507#4127374 , @aaronmondal > wrote: > >> I think unless conflicts arise creating an issue similar to this >>

[PATCH] D142507: [AMDGPU] Split dot7 feature

rampitec added a comment. In D142507#4127374 , @aaronmondal wrote: > I think unless conflicts arise creating an issue similar to this > https://github.com/llvm/llvm-project/issues/60600 with the `cherry-pick` line > set to this commit should be

[PATCH] D142507: [AMDGPU] Split dot7 feature

aaronmondal added a comment. I think unless conflicts arise creating an issue similar to this https://github.com/llvm/llvm-project/issues/60600 with the `cherry-pick` line set to this commit should be enough. (See also https://llvm.org/docs/GitHub.html). Repository: rG LLVM Github Monorepo

[PATCH] D142507: [AMDGPU] Split dot7 feature

rampitec added a comment. In D142507#4127275 , @aaronmondal wrote: >> I cannot say there was much choice. The only real choice was to postpone the >> split and magnify the problem in the future. As for the ifdefs, this might >> be possible in the

[PATCH] D142507: [AMDGPU] Split dot7 feature

aaronmondal added a comment. > I cannot say there was much choice. The only real choice was to postpone the > split and magnify the problem in the future. As for the ifdefs, this might be > possible in the device-libs but I do not see how to do it the Builtins.def. Hmm maybe ifdefs in the

[PATCH] D142507: [AMDGPU] Split dot7 feature

rampitec added a comment. In D142507#4127167 , @aaronmondal wrote: > Well, I can already feel the pain that distro maintainers having to build the > next ROCm releases  > > I wonder what the better course of action is here: > > 1. Port this patch to

[PATCH] D142507: [AMDGPU] Split dot7 feature

aaronmondal added a comment. Well, I can already feel the pain that distro maintainers having to build the next ROCm releases  I wonder what the better course of action is here: 1. Port this patch to Clang 16 so that users with new hardware will be able to build ROCm 5.5, but make it

[PATCH] D142507: [AMDGPU] Split dot7 feature

rampitec added a comment. In D142507#4126864 , @aaronmondal wrote: >> It shall be complimented by the device-lib change in the corresponding >> release, so it is not that simple. > > @rampitec I'm not sure I understand. Does this mean that this is

[PATCH] D142507: [AMDGPU] Split dot7 feature

aaronmondal added a comment. > It shall be complimented by the device-lib change in the corresponding > release, so it is not that simple. @rampitec I'm not sure I understand. Does this mean that this is breaking in a way that Clang 17 won't be able to build ROCm 5.4? I thought it was like

[PATCH] D142507: [AMDGPU] Split dot7 feature

arsenm added inline comments. Comment at: clang/include/clang/Basic/BuiltinsAMDGPU.def:239 -TARGET_BUILTIN(__builtin_amdgcn_fdot2, "fV2hV2hfIb", "nc", "dot7-insts") +TARGET_BUILTIN(__builtin_amdgcn_fdot2, "fV2hV2hfIb", "nc", "dot10-insts")

[PATCH] D142507: [AMDGPU] Split dot7 feature

rampitec added a comment. In D142507#4125940 , @aaronmondal wrote: > Would it be possible to backport this to Clang 16? > > If > https://github.com/RadeonOpenCompute/ROCm-Device-Libs/commit/8dc779e19cbf2ccfd3307b60f7db57cf4203a5be > makes it into ROCm

[PATCH] D142507: [AMDGPU] Split dot7 feature

aaronmondal added subscribers: jhuber6, aaronmondal. aaronmondal added a comment. Would it be possible to backport this to Clang 16? If https://github.com/RadeonOpenCompute/ROCm-Device-Libs/commit/8dc779e19cbf2ccfd3307b60f7db57cf4203a5be makes it into ROCm 5.5 no distro would be able to build

[PATCH] D142507: [AMDGPU] Split dot7 feature

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. rampitec marked an inline comment as done. Closed by commit rGdf0488369d32: [AMDGPU] Split dot7 feature (authored by rampitec). Herald added a project: clang. Herald