[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

2023-02-01 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 493978. tianshilei1992 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/ https://reviews.llvm.org/D142569 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

2023-01-28 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 added inline comments. Comment at: openmp/libomptarget/plugins/cuda/src/rtl.cpp:26 #include "Debug.h" -#include "DeviceEnvironment.h" +#include "Environment.h" #include "omptarget.h" These changes in old plugins will be gone because the old

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

2023-01-28 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 493043. tianshilei1992 added a comment. rebase and fix bugs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/ https://reviews.llvm.org/D142569 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

2023-01-28 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 493019. tianshilei1992 added a comment. rebase and fix bugs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/ https://reviews.llvm.org/D142569 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

2023-01-26 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 492495. tianshilei1992 added a comment. rebase and fix problems Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/ https://reviews.llvm.org/D142569 Files:

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

2023-01-25 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 492322. tianshilei1992 added a comment. fix bugs and add plugin support Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/ https://reviews.llvm.org/D142569 Files:

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

2023-01-25 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 492316. tianshilei1992 added a comment. rebase, fix comments, added more code. features are finished now. time to move to tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

2023-01-25 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 added inline comments. Comment at: openmp/libomptarget/DeviceRTL/src/Configuration.cpp:57 + return !__omp_rtl_assume_no_nested_parallelism || + state::getKernelEnvironment().Configuration.MayUseNestedParallelism; } jdoerfert wrote: >

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

2023-01-25 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added inline comments. Comment at: openmp/libomptarget/DeviceRTL/src/Configuration.cpp:57 + return !__omp_rtl_assume_no_nested_parallelism || + state::getKernelEnvironment().Configuration.MayUseNestedParallelism; } This looks wrong. We want

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

2023-01-25 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 added inline comments. Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:2544 - ~AAExecutionDomainFunction() { -delete RPOT; - } + ~AAExecutionDomainFunction() { delete RPOT; } This will be removed properly later. Repository: rG

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

2023-01-25 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 492278. tianshilei1992 marked 6 inline comments as done. tianshilei1992 added a comment. rebase, add more code, fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

2023-01-25 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. Link the old review too. Pre-commit, w/o review, the file rename and include changes. Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:246 + GET_KERNEL_ENVIRONMENT_MEMBER(Configuration, DL, StructC)), \ + V)) +

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

2023-01-25 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 added inline comments. Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:3479-3486 + /// Return the IdentTy (ident_ty) corresponding to the associated kernel. + Constant *getKernelIdent(ConstantStruct *StructC) { +GlobalVariable *KernelEnvGV =

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

2023-01-25 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. Description not clear Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:3912-3914 + Constant *KernelEnvironmentCasted = + ConstantExpr::getPointerBitCastOrAddrSpaceCast(KernelEnvironment, +

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

2023-01-25 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 created this revision. Herald added subscribers: kosarev, ormris, kerbowa, guansong, hiraditya, yaxunl, jvesely. Herald added a project: All. tianshilei1992 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a reviewer: jdoerfert. Herald added a