This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG943ef0642010: [clang][Interp] Check This pointer without
creating InterpFrame (authored by tbaeder).
Repository:
rG LLVM Github Monorepo
CHANGES
shafik accepted this revision.
shafik added a comment.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142617/new/
https://reviews.llvm.org/D142617
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142617/new/
https://reviews.llvm.org/D142617
___
cfe-commits mailing
tbaeder updated this revision to Diff 501502.
tbaeder added a comment.
Added an `aligned()` assertion and renamed the old `peek(unsigned Offset)`
returning a `void*` to `peekData()`, so both `peek` overloads are now public
member functions.
CHANGES SINCE LAST ACTION
aaron.ballman added inline comments.
Comment at: clang/lib/AST/Interp/InterpStack.h:70-72
+ template T (size_t Offset) const {
+return *reinterpret_cast(peek(Offset));
+ }
Ooofda, this only differs from `peek()` on line 97 because this function has a
tbaeder added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142617/new/
https://reviews.llvm.org/D142617
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
tbaeder added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142617/new/
https://reviews.llvm.org/D142617
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
The InterpFrame was only created so early so we
