[PATCH] D142637: A slightly more concise AST dump :)

2023-02-10 Thread Dani Ferreira Franco Moura via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG70acb3aab3a1: A slightly more concise AST dump :) (authored by merrymeerkat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142637: A slightly more concise AST dump :)

2023-01-31 Thread Dani Ferreira Franco Moura via Phabricator via cfe-commits
merrymeerkat marked 3 inline comments as done. merrymeerkat added a comment. thank you @sammccall @gribozavr2 for spotting these issues! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142637/new/ https://reviews.llvm.org/D142637

[PATCH] D142637: A slightly more concise AST dump :)

2023-01-31 Thread Dani Ferreira Franco Moura via Phabricator via cfe-commits
merrymeerkat updated this revision to Diff 493557. merrymeerkat added a comment. Addressing review comments (improve tests) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142637/new/ https://reviews.llvm.org/D142637 Files:

[PATCH] D142637: A slightly more concise AST dump :)

2023-01-26 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clang/test/AST/ast-dump-attr-type.cpp:12 +// CHECK-NEXT:`-BuiltinType 0x{{[^ ]*}} 'int' +// CHECK-NOT: `-PointerType 0x564c31a07520 'int *' gribozavr2 wrote: > sammccall wrote: > > Can you add a second

[PATCH] D142637: A slightly more concise AST dump :)

2023-01-26 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 added inline comments. Comment at: clang/test/AST/ast-dump-attr-type.cpp:12 +// CHECK-NEXT:`-BuiltinType 0x{{[^ ]*}} 'int' +// CHECK-NOT: `-PointerType 0x564c31a07520 'int *' sammccall wrote: > Can you add a second example where the

[PATCH] D142637: A slightly more concise AST dump :)

2023-01-26 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/AST/ast-dump-attr-type.cpp:12 +// CHECK-NEXT:`-BuiltinType 0x{{[^ ]*}} 'int' +// CHECK-NOT: `-PointerType 0x564c31a07520 'int