This revision was automatically updated to reflect the committed changes.
Closed by commit rG5b37cddff8e0: [clang-tidy] Introduce HeaderFileExtensions
and ImplementationFileExtensions… (authored by carlosgalvezp).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
carlosgalvezp updated this revision to Diff 496924.
carlosgalvezp added a comment.
- Rebase.
- Fix code directly for the newly introduce check in llvmlibc. We do not need
the deprecation process here since the check is brand new.
- Rebase the getter functions from ClangTidyCheck.h, they don't
carlosgalvezp added a comment.
Friendly ping @njames93 . Since there are more checks coming up introducing
more debt and duplication, I believe we should land this rather soon. I intend
to land this by Feb 19th if I don't receive any more feedback.
Repository:
rG LLVM Github Monorepo
carlosgalvezp updated this revision to Diff 496346.
carlosgalvezp added a comment.
Document options now that the documentation improvement
patch is merged.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142655/new/
https://reviews.llvm.org/D142655
Eugene.Zelenko accepted this revision.
Eugene.Zelenko added a comment.
This revision is now accepted and ready to land.
Looks OK for me, but please wait for other opinion(s).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142655/new/
carlosgalvezp added inline comments.
Comment at:
clang-tools-extra/clang-tidy/bugprone/DynamicStaticInitializersCheck.cpp:31
+: ClangTidyCheck(Name, Context) {
+ std::optional HeaderFileExtensionsOption =
+ Options.get("HeaderFileExtensions");
Eugene.Zelenko added inline comments.
Comment at:
clang-tools-extra/clang-tidy/bugprone/DynamicStaticInitializersCheck.cpp:31
+: ClangTidyCheck(Name, Context) {
+ std::optional HeaderFileExtensionsOption =
+ Options.get("HeaderFileExtensions");
Will
carlosgalvezp updated this revision to Diff 494894.
carlosgalvezp added a comment.
Fix release notes, ImplementationFileExtensions only
applies to one check.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142655/new/
carlosgalvezp updated this revision to Diff 494893.
carlosgalvezp edited the summary of this revision.
carlosgalvezp added a comment.
Update commit message
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142655/new/
https://reviews.llvm.org/D142655
carlosgalvezp updated this revision to Diff 494892.
carlosgalvezp added a comment.
Remove unneeded newlines and braces in single-line
if/else statements.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142655/new/
https://reviews.llvm.org/D142655
carlosgalvezp updated this revision to Diff 494889.
carlosgalvezp edited the summary of this revision.
carlosgalvezp added a comment.
Update commit message to clarify the difference
between the first attempt and this one.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
carlosgalvezp updated this revision to Diff 494888.
carlosgalvezp added a comment.
Use get functions from ClangTidyCheck instead of Context
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142655/new/
https://reviews.llvm.org/D142655
Files:
carlosgalvezp updated this revision to Diff 494886.
carlosgalvezp retitled this revision from "[WIP][clang-tidy] Introduce
HeaderFileExtensions and ImplementationFileExtensions options" to "[clang-tidy]
Introduce HeaderFileExtensions and ImplementationFileExtensions options".
carlosgalvezp
carlosgalvezp created this revision.
Herald added a subscriber: xazax.hun.
Herald added a reviewer: njames93.
Herald added a project: All.
carlosgalvezp requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
Re-introduce it, now with
14 matches
Mail list logo
