[PATCH] D142823: Intrinsics: Allow tablegen to mark parameters with dereferenceable

arsenm closed this revision. arsenm added a comment. 1717c18664d5880f78db85eb0075a2c1379df2d9 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142823/new/ https://reviews.llvm.org/D142823

[PATCH] D142823: Intrinsics: Allow tablegen to mark parameters with dereferenceable

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142823/new/ https://reviews.llvm.org/D142823 ___ cfe-commits mailing list

[PATCH] D142823: Intrinsics: Allow tablegen to mark parameters with dereferenceable

arsenm updated this revision to Diff 529074. arsenm added a comment. Split out amdgpu parts CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142823/new/ https://reviews.llvm.org/D142823 Files: llvm/include/llvm/IR/Intrinsics.td llvm/test/TableGen/intrin-side-effects.td

[PATCH] D142823: Intrinsics: Allow tablegen to mark parameters with dereferenceable

foad added a comment. In D142823#4093363 , @arsenm wrote: > In D142823#4093357 , @foad wrote: > >> I think the tablegen functionality should be a separate patch from the >> amdgpu changes. > > Maybe, but then

[PATCH] D142823: Intrinsics: Allow tablegen to mark parameters with dereferenceable

arsenm added a comment. In D142823#4093357 , @foad wrote: > I think the tablegen functionality should be a separate patch from the amdgpu > changes. Maybe, but then it’s untested in the patch which adds it CHANGES SINCE LAST ACTION

[PATCH] D142823: Intrinsics: Allow tablegen to mark parameters with dereferenceable

foad added a comment. I think the tablegen functionality should be a separate patch from the amdgpu changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142823/new/ https://reviews.llvm.org/D142823 ___ cfe-commits mailing list

[PATCH] D142823: Intrinsics: Allow tablegen to mark parameters with dereferenceable

arsenm updated this revision to Diff 493566. arsenm added a comment. Revert implicitarg.ptr changes since not-HSA has different alignment for no reason. Also with the size differences between amdhsa and different CO versions we're already wrong for emitting 256 unconditionally CHANGES SINCE

[PATCH] D142823: Intrinsics: Allow tablegen to mark parameters with dereferenceable

arsenm created this revision. arsenm added reviewers: sstefan1, jdoerfert, yaxunl, AMDGPU, nikic, alexander-shaposhnikov. Herald added subscribers: kosarev, StephenFan, kerbowa, jvesely. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. Herald