[PATCH] D142878: Add testing for Fuchsia multilib

2023-02-06 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings abandoned this revision. michaelplatings added a comment. > A more scalable approach would be to check only the minimal set of > combination necessary to achieve full coverage. In that case the testing you've already got in place in `clang/test/Driver/fuchsia.cpp` is adequate.

[PATCH] D142878: Add testing for Fuchsia multilib

2023-02-04 Thread Petr Hosek via Phabricator via cfe-commits
phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:316-317 +void Fuchsia::configureMultilibFlags(Multilib::flags_list , + bool Exceptions, bool Asan, bool Hwasan, + bool

[PATCH] D142878: Add testing for Fuchsia multilib

2023-02-02 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings updated this revision to Diff 494258. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142878/new/ https://reviews.llvm.org/D142878 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp

[PATCH] D142878: Add testing for Fuchsia multilib

2023-02-01 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. Thanks, some of these are no longer needed which could simplify this change so I sent out D143050 to clean up the Fuchsia driver first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142878: Add testing for Fuchsia multilib

2023-01-30 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings updated this revision to Diff 493244. michaelplatings added a comment. Update commit message and run arc with clang-format on the PATH Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142878/new/ https://reviews.llvm.org/D142878

[PATCH] D142878: Add testing for Fuchsia multilib

2023-01-30 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The plan is to