[PATCH] D142905: [Driver] Change multilib selection algorithm

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd30bc9e91241: [Driver] Change multilib selection algorithm (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D142905: [Driver] Change multilib selection algorithm

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/ https://reviews.llvm.org/D142905 ___ cfe-commits mailing list

[PATCH] D142905: [Driver] Change multilib selection algorithm

michaelplatings updated this revision to Diff 507864. michaelplatings added a comment. Move change to print options into D146757 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/

[PATCH] D142905: [Driver] Change multilib selection algorithm

michaelplatings updated this revision to Diff 507527. michaelplatings marked an inline comment as done. michaelplatings added a comment. Add enum to Multilib class for how print options should be calculated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142905: [Driver] Change multilib selection algorithm

phosek added inline comments. Comment at: clang/lib/Driver/MultilibBuilder.cpp:88 +static Multilib::flags_list getPrintOptions(const Multilib::flags_list ) { + // Derive print options from flags. Would it be possible to move this method directly into

[PATCH] D142905: [Driver] Change multilib selection algorithm

michaelplatings added a comment. @phosek ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/ https://reviews.llvm.org/D142905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D142905: [Driver] Change multilib selection algorithm

michaelplatings updated this revision to Diff 506044. michaelplatings added a comment. fix typo in comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/ https://reviews.llvm.org/D142905 Files: clang/include/clang/Driver/Multilib.h

[PATCH] D142905: [Driver] Change multilib selection algorithm

michaelplatings updated this revision to Diff 505279. michaelplatings marked an inline comment as done. michaelplatings added a comment. Calculate the output for -print-multi-lib lazily. This necessitated returning to using std::vector to store flags to avoid reordering them. In theory the big-O

[PATCH] D142905: [Driver] Change multilib selection algorithm

phosek added a comment. I have just one comment related to efficiency, but if it turns out to be too difficult to address, I'd be also fine landing this change as is and addressing that issue in a follow up change. Comment at: clang/lib/Driver/MultilibBuilder.cpp:94-100 +

[PATCH] D142905: [Driver] Change multilib selection algorithm

michaelplatings marked an inline comment as done. michaelplatings added inline comments. Comment at: clang/include/clang/Driver/Multilib.h:67 + /// a subset of the flags derived from the Clang command line options. + const flag_set () const { return Flags; }

[PATCH] D142905: [Driver] Change multilib selection algorithm

peter.smith accepted this revision. peter.smith added a comment. This revision is now accepted and ready to land. I've set approved from the Arm side. Please leave some time for people in the US time zone to leave any final comments or ask for extensions. I've left a suggestion for a comment,

[PATCH] D142905: [Driver] Change multilib selection algorithm

michaelplatings added inline comments. Comment at: clang/include/clang/Driver/Multilib.h:41 + flag_set Flags; + arg_list PrintArgs; phosek wrote: > This is just a suggestion, but GCC documentation refers to these as either > "options" or "switches", not

[PATCH] D142905: [Driver] Change multilib selection algorithm

michaelplatings updated this revision to Diff 499791. michaelplatings marked 2 inline comments as done. michaelplatings added a comment. - Rename args to options as suggested by @phosek - Add more comments to hopefully make the difference between flags and options clearer. Repository: rG

[PATCH] D142905: [Driver] Change multilib selection algorithm

phosek added inline comments. Comment at: clang/include/clang/Driver/Multilib.h:41 + flag_set Flags; + arg_list PrintArgs; This is just a suggestion, but GCC documentation refers to these as either "options" or "switches", not "args" so I think it might be