[PATCH] D142905: Change multilib selection algorithm

michaelplatings updated this revision to Diff 499416. michaelplatings marked 2 inline comments as done. michaelplatings added a comment. Remove braces as requested by @MaskRay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/

[PATCH] D142905: Change multilib selection algorithm

MaskRay added a comment. Mention `MultilibSet::select` in the summary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/ https://reviews.llvm.org/D142905 ___ cfe-commits mailing list

[PATCH] D142905: Change multilib selection algorithm

MaskRay added inline comments. Comment at: clang/lib/Driver/Multilib.cpp:53 + for (StringRef Flag : PrintArgs) { +OS << "@" << Flag.substr(1); } remove braces Comment at: clang/lib/Driver/Multilib.cpp:99 + multilib_list Result =

[PATCH] D142905: Change multilib selection algorithm

MaskRay added a comment. Use `[Driver] ` for pure driver patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/ https://reviews.llvm.org/D142905 ___ cfe-commits mailing list

[PATCH] D142905: Change multilib selection algorithm

peter.smith added a comment. Thanks for the updates, I'm happy with the changes and don't have any more comments. Happy to give my implicit approval. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/ https://reviews.llvm.org/D142905

[PATCH] D142905: Change multilib selection algorithm

michaelplatings updated this revision to Diff 495800. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/ https://reviews.llvm.org/D142905 Files: clang/include/clang/Driver/Multilib.h

[PATCH] D142905: Change multilib selection algorithm

michaelplatings added inline comments. Comment at: clang/include/clang/Driver/Multilib.h:31 public: - using flags_list = std::vector; + using flags_list = std::set; + using arg_list = std::vector; peter.smith wrote: > would flags_set be a better name. I'm

[PATCH] D142905: Change multilib selection algorithm

michaelplatings updated this revision to Diff 495532. michaelplatings marked an inline comment as done. michaelplatings added a comment. Apply improvements suggested by @peter.smith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/

[PATCH] D142905: Change multilib selection algorithm

michaelplatings updated this revision to Diff 495463. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/ https://reviews.llvm.org/D142905 Files: clang/include/clang/Driver/Multilib.h

[PATCH] D142905: Change multilib selection algorithm

peter.smith added a comment. A couple of small stylisitic suggestions. Comment at: clang/include/clang/Driver/Multilib.h:31 public: - using flags_list = std::vector; + using flags_list = std::set; + using arg_list = std::vector; would flags_set be a better

[PATCH] D142905: Change multilib selection algorithm

michaelplatings updated this revision to Diff 495070. michaelplatings added a comment. Set both fexceptions and fno-exceptions flags for Fuchsia multilib. Previously that tweak had slipped into D142878 , which is now abandoned. Repository: rG LLVM Github

[PATCH] D142905: Change multilib selection algorithm

michaelplatings updated this revision to Diff 494260. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/ https://reviews.llvm.org/D142905 Files: clang/include/clang/Driver/Multilib.h

[PATCH] D142905: Change multilib selection algorithm

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added subscribers: abrachet, mgrang. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The new