[PATCH] D142932: [NFC] Multilib YAML parsing

michaelplatings updated this revision to Diff 499443. michaelplatings added a subscriber: peter.smith. michaelplatings added a comment. - Squash D143763 into this change as suggested by @MaskRay - Use PascalCase field names as requested by @phosek - Applied

[PATCH] D142932: [NFC] Multilib YAML parsing

phosek added a comment. For the existing YAML files within LLVM, we most commonly used the `PascalCase` for field names and less commonly `lisp-case`. This change uses `camelCase` which is unusual and unless there's a particular reason for using this scheme such as compatibility with an

[PATCH] D142932: [NFC] Multilib YAML parsing

MaskRay added a comment. Adding new APIs is usually not considered `NFC`. Just remove the tag. Comment at: clang/lib/Driver/Multilib.cpp:115 +if (!StringRef(M.Regex).starts_with("^")) { + RegexString.insert(RegexString.begin(), '^'); +}

[PATCH] D142932: [NFC] Multilib YAML parsing

michaelplatings updated this revision to Diff 496534. michaelplatings added a comment. Make "variants" required Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/ https://reviews.llvm.org/D142932 Files:

[PATCH] D142932: [NFC] Multilib YAML parsing

michaelplatings added a comment. In D142932#4111925 , @phosek wrote: > Do you know if regular expressions are necessary to cover the existing use > cases? Yes. One use case is mapping later architecture versions to the last architecture version

[PATCH] D142932: [NFC] Multilib YAML parsing

phosek added a comment. Do you know if regular expressions are necessary to cover the existing use cases? In our experience, while regular expressions are powerful, they also tend to be error prone and more difficult to reason about. Would glob patterns that are implemented by

[PATCH] D142932: [NFC] Multilib YAML parsing

michaelplatings updated this revision to Diff 495554. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/ https://reviews.llvm.org/D142932 Files: clang/include/clang/Driver/Multilib.h