[PATCH] D142933: Add -print-multi-selection-flags-experimental option

2023-06-07 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings updated this revision to Diff 529313. michaelplatings marked 2 inline comments as done. michaelplatings added a comment. Rename option and support fewer options as suggested by @phosek Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142933: Add -print-multi-selection-flags-experimental option

2023-06-06 Thread Petr Hosek via Phabricator via cfe-commits
phosek added inline comments. Comment at: clang/include/clang/Driver/Options.td:4261 def print_multi_lib : Flag<["-", "--"], "print-multi-lib">; +def print_multi_selection_flags : Flag<["-", "--"], "print-multi-selection-flags-experimental">, + HelpText<"Print the flags used

[PATCH] D142933: Add -print-multi-selection-flags-experimental option

2023-06-06 Thread Petr Hosek via Phabricator via cfe-commits
phosek added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:250-285 + // Enumerate boolean flags we care about for the purposes of multilib here. + // There must be a smarter way to do it but this gets us started. + const struct HasFlag { +ID Pos, Neg; +

[PATCH] D142933: Add -print-multi-selection-flags-experimental option

2023-06-06 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings updated this revision to Diff 529013. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/ https://reviews.llvm.org/D142933 Files: clang/include/clang/Driver/Options.td

[PATCH] D142933: Add -print-multi-selection-flags-experimental option

2023-05-03 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings updated this revision to Diff 519000. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/ https://reviews.llvm.org/D142933 Files: clang/include/clang/Driver/Options.td

[PATCH] D142933: Add -print-multi-selection-flags-experimental option

2023-03-24 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings updated this revision to Diff 508037. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/ https://reviews.llvm.org/D142933 Files: clang/include/clang/Driver/Options.td

[PATCH] D142933: Add -print-multi-selection-flags-experimental option

2023-03-15 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:237-245 + // Enumerate boolean flags we care about for the purposes of multilib here. + // There must be a smarter way to do it but this gets us started. + const struct HasFlag { +ID Pos,

[PATCH] D142933: Add -print-multi-selection-flags-experimental option

2023-03-15 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings updated this revision to Diff 505643. michaelplatings marked 2 inline comments as done. michaelplatings added a comment. Rebase on D146141 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/

[PATCH] D142933: Add -print-multi-selection-flags-experimental option

2023-03-14 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings updated this revision to Diff 505284. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/ https://reviews.llvm.org/D142933 Files: clang/include/clang/Driver/Options.td

[PATCH] D142933: Add -print-multi-selection-flags-experimental option

2023-03-09 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings updated this revision to Diff 503902. michaelplatings added a comment. flags -> tags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/ https://reviews.llvm.org/D142933 Files: clang/include/clang/Driver/Options.td