[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4eebc8674e1: [Driver] Enable multilib.yaml in the BareMetal ToolChain (authored by michaelplatings). Repository: rG LLVM Github Monorepo

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 529565. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 ___ cfe-commits mailing list

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 529315. michaelplatings marked an inline comment as done. michaelplatings added a comment. Change string literal as suggested by @phosek Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:176 + +#define MULTILIB_YAML_FILENAME "multilib.yaml" + This is not idiomatic, I couldn't find any instance of `#define` for string literals anywhere in LLVM. I believe the

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:183 - SmallString<128> SysRootDir; - llvm::sys::path::append(SysRootDir, getDriver().Dir, "../lib/clang-runtimes", - getDriver().getTargetTriple());

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 529016. michaelplatings marked an inline comment as done. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files:

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:180 + SmallString<128> SysRootDir(D.Dir); + llvm::sys::path::append(SysRootDir, "../lib/clang-runtimes"); + Defer to `llvm::sys::path::append` for joining the path components

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 519001. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChains/Arch/ARM.cpp

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 508038. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 505644. michaelplatings added a comment. Rebase on D146141 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files:

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:184 + SmallString<128> MultilibPath(SysRootDir); + llvm::sys::path::append(MultilibPath, MULTILIB_YAML_FILENAME); + phosek wrote: > Rather than hardcoding the filename

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 505286. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 505050. michaelplatings added a comment. tags->flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:184 + SmallString<128> MultilibPath(SysRootDir); + llvm::sys::path::append(MultilibPath, MULTILIB_YAML_FILENAME); + Rather than hardcoding the filename and the location, which

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

abidh accepted this revision. abidh added a comment. The BareMetal.cpp part looks ok to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 ___ cfe-commits

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 504772. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

peter.smith accepted this revision. peter.smith added a comment. This revision is now accepted and ready to land. I've set approved from the Arm side. Please leave some time for people in the US time zone to leave any final comments or ask for extensions. Repository: rG LLVM Github Monorepo

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 503903. michaelplatings added a comment. flags -> tags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 499953. michaelplatings added a comment. PrintArgs -> PrintOptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings added inline comments. Comment at: clang/test/Driver/baremetal-multilib.cpp:14 +// RUN: | FileCheck %s +// CHECK: "{{.*}}clang{{.*}}" "-cc1" "-triple" "thumbv8m.main-none-unknown-eabihf" +// CHECK-SAME: "-internal-isystem"

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 499479. michaelplatings marked 6 inline comments as done. michaelplatings added a comment. Apply changes requested by @peter.smith and @MaskRay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

MaskRay added inline comments. Comment at: clang/test/Driver/baremetal-multilib.cpp:19 +// CHECK-NEXT: "{{[^"]*}}ld{{(\.(lld|bfd|gold))?}}{{(\.exe)?}}" "{{.*}}.o" "-Bstatic" +// CHECK-SAME:

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:167 + std::vector ArgsFlags = TC.getMultiSelectionFlags(Args); + + if (!Result.Multilibs.parse(*MB.get())) { delete blank line Comment at:

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 496537. michaelplatings added a comment. Add clangMinimumVersion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

peter.smith added a comment. Looks good to me. Some small suggestions around execute-only as I expect this to be a useful multilib variant. Comment at: clang/lib/Driver/ToolChain.cpp:198 unsigned FPUKind = llvm::ARM::FK_INVALID; - tools::arm::getARMTargetFeatures(D,

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 495658. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 495557. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 494414. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added subscribers: abidh, kristof.beyls. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The